Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757345AbaDWNyE (ORCPT ); Wed, 23 Apr 2014 09:54:04 -0400 Received: from ns.mm-sol.com ([37.157.136.199]:33003 "EHLO extserv.mm-sol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751351AbaDWNx7 (ORCPT ); Wed, 23 Apr 2014 09:53:59 -0400 Message-ID: <1398261183.4724.226.camel@iivanov-dev> Subject: Re: [PATCH v6 15/19] usb: phy: msm: Fix PTS definitions for MSM USB controller From: "Ivan T. Ivanov" To: Sergei Shtylyov Cc: Felipe Balbi , Tim Bird , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Tim Bird Date: Wed, 23 Apr 2014 16:53:03 +0300 In-Reply-To: <5357C40E.7060000@cogentembedded.com> References: <1398158438-21579-1-git-send-email-iivanov@mm-sol.com> <1398158438-21579-16-git-send-email-iivanov@mm-sol.com> <53566A23.8010508@cogentembedded.com> <1398259477.4724.218.camel@iivanov-dev> <1398260102.4724.223.camel@iivanov-dev> <5357C40E.7060000@cogentembedded.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.1-2ubuntu2~saucy1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2014-04-23 at 17:45 +0400, Sergei Shtylyov wrote: > Hello. > > On 23-04-2014 17:35, Ivan T. Ivanov wrote: > > >>>> --- a/include/linux/usb/msm_hsusb_hw.h > >>>> +++ b/include/linux/usb/msm_hsusb_hw.h > >>>> @@ -31,8 +31,9 @@ > >>>> #define USB_USBINTR (MSM_USB_BASE + 0x0148) > >>>> > >>>> #define PORTSC_PHCD (1 << 23) /* phy suspend mode */ > >>>> -#define PORTSC_PTS_MASK (3 << 30) > >>>> -#define PORTSC_PTS_ULPI (3 << 30) > >>>> +#define PORTSC_PTS_MASK (3 << 30) > >>>> +#define PORTSC_PTS_ULPI (2 << 30) > >>>> +#define PORTSC_PTS_SERIAL (3 << 30) > > >>> Please use tabs, not spaces here. > > >> Thanks, will fix and resend. > > > I answered too quickly. File contain tabs and spaces for > > indentation of definitions. > > You mean tabs and spaces on one line? Or sometimes tabs, sometimes spaces? In this particular hunk, original code uses spaces. Ivan > > > Should I still use tabs here? > > If they are already used, why not? > > > Regards, > > Ivan > > WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/