Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755619AbaDWOJm (ORCPT ); Wed, 23 Apr 2014 10:09:42 -0400 Received: from mail-la0-f46.google.com ([209.85.215.46]:46180 "EHLO mail-la0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752965AbaDWOJj (ORCPT ); Wed, 23 Apr 2014 10:09:39 -0400 Message-ID: <5357C99F.6070009@cogentembedded.com> Date: Wed, 23 Apr 2014 18:09:35 +0400 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: "Ivan T. Ivanov" CC: Felipe Balbi , Tim Bird , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Tim Bird Subject: Re: [PATCH v6 15/19] usb: phy: msm: Fix PTS definitions for MSM USB controller References: <1398158438-21579-1-git-send-email-iivanov@mm-sol.com> <1398158438-21579-16-git-send-email-iivanov@mm-sol.com> <53566A23.8010508@cogentembedded.com> <1398259477.4724.218.camel@iivanov-dev> <1398260102.4724.223.camel@iivanov-dev> <5357C40E.7060000@cogentembedded.com> <1398261183.4724.226.camel@iivanov-dev> In-Reply-To: <1398261183.4724.226.camel@iivanov-dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23-04-2014 17:53, Ivan T. Ivanov wrote: >>>>>> --- a/include/linux/usb/msm_hsusb_hw.h >>>>>> +++ b/include/linux/usb/msm_hsusb_hw.h >>>>>> @@ -31,8 +31,9 @@ >>>>>> #define USB_USBINTR (MSM_USB_BASE + 0x0148) >>>>>> >>>>>> #define PORTSC_PHCD (1 << 23) /* phy suspend mode */ >>>>>> -#define PORTSC_PTS_MASK (3 << 30) >>>>>> -#define PORTSC_PTS_ULPI (3 << 30) >>>>>> +#define PORTSC_PTS_MASK (3 << 30) >>>>>> +#define PORTSC_PTS_ULPI (2 << 30) >>>>>> +#define PORTSC_PTS_SERIAL (3 << 30) >>>>> Please use tabs, not spaces here. >>>> Thanks, will fix and resend. >>> I answered too quickly. File contain tabs and spaces for >>> indentation of definitions. >> You mean tabs and spaces on one line? Or sometimes tabs, sometimes spaces? > In this particular hunk, original code uses spaces. That I saw. 8-) I was asking about this file in general. > Ivan >>> Should I still use tabs here? >> If they are already used, why not? >>> Regards, >>> Ivan WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/