Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755344AbaDWPod (ORCPT ); Wed, 23 Apr 2014 11:44:33 -0400 Received: from mail-oa0-f44.google.com ([209.85.219.44]:55713 "EHLO mail-oa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752451AbaDWPob (ORCPT ); Wed, 23 Apr 2014 11:44:31 -0400 MIME-Version: 1.0 In-Reply-To: <20140423153544.GD25378@pd.tnic> References: <1394739386-22260-1-git-send-email-venkateshs@google.com> <20140423144538.GN11096@twins.programming.kicks-ass.net> <20140423150912.GO11096@twins.programming.kicks-ass.net> <20140423151638.GA8526@pd.tnic> <20140423153544.GD25378@pd.tnic> Date: Wed, 23 Apr 2014 17:44:30 +0200 Message-ID: Subject: Re: [PATCH] perf/x86/intel: Use rdmsrl_safe when initializing RAPL PMU. From: Stephane Eranian To: Borislav Petkov Cc: Peter Zijlstra , Venkatesh Srinivas , LKML , "mingo@elte.hu" , "ak@linux.intel.com" , "Yan, Zheng" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 23, 2014 at 5:35 PM, Borislav Petkov wrote: > On Wed, Apr 23, 2014 at 05:18:29PM +0200, Stephane Eranian wrote: >> On Wed, Apr 23, 2014 at 5:16 PM, Borislav Petkov wrote: >> > On Wed, Apr 23, 2014 at 05:14:33PM +0200, Stephane Eranian wrote: >> >> Wouldn't rdmsrl_safe() return 0 on success? >> > >> > Yes. >> > >> then the if() test is wrong: >> if (!rdmsrl_safe()) >> return -1; >> >> Should be: >> if (rdmsrl_safe()) >> return -1; >> >> Or am I missing something? > > Yeah, that is wrong: > > if (!rdmsrl_safe(MSR_RAPL_POWER_UNIT, &msr_rapl_power_unit_bits)) > return -1; > > On error we return -EIO, on success 0. Just remove the "!". > Yeah, will post a patch ASAP. A comment describing return values where rdmsrl_safe() is defined would maybe help avoid problems in the future. Thanks. > > -- > Regards/Gruss, > Boris. > > Sent from a fat crate under my desk. Formatting is fine. > -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/