Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932371AbaDWQna (ORCPT ); Wed, 23 Apr 2014 12:43:30 -0400 Received: from mail-ve0-f177.google.com ([209.85.128.177]:43362 "EHLO mail-ve0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753668AbaDWQnW (ORCPT ); Wed, 23 Apr 2014 12:43:22 -0400 MIME-Version: 1.0 In-Reply-To: References: <1398210681-22976-1-git-send-email-dianders@chromium.org> Date: Wed, 23 Apr 2014 09:43:21 -0700 X-Google-Sender-Auth: bJyy3D0rwJk5yoqvRCeGKJOxOrc Message-ID: Subject: Re: [PATCH] mmc: dw_mmc: Don't print data errors From: Doug Anderson To: Ulf Hansson , Seungwon Jeon Cc: Jaehoon Chung , Yuvaraj Kumar C D , Alim Akhtar , Sonny Rao , linux-samsung-soc , Chris Ball , linux-mmc , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Seungwon / Ulf, On Wed, Apr 23, 2014 at 1:17 AM, Ulf Hansson wrote: > On 23 April 2014 01:51, Doug Anderson wrote: >> Data errors are completely expected during tuning. Printing them out >> is confusing people looking at the kernel logs. They see things like: >> >> [ 3.613296] dwmmc_exynos 12200000.dwmmc0: data error, status 0x00000088 >> >> ...and they think something is wrong with their hardware. >> >> Remove the printouts. We'll leave it up to a higher level to report >> about errors. >> >> Signed-off-by: Doug Anderson >> --- >> drivers/mmc/host/dw_mmc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c >> index cced599..4c8d423 100644 >> --- a/drivers/mmc/host/dw_mmc.c >> +++ b/drivers/mmc/host/dw_mmc.c >> @@ -1248,7 +1248,7 @@ static int dw_mci_data_complete(struct dw_mci *host, struct mmc_data *data) >> data->error = -EIO; >> } >> >> - dev_err(host->dev, "data error, status 0x%08x\n", status); >> + dev_dbg(host->dev, "data error, status 0x%08x\n", status); >> > > The "status" here could be useful information about the status > register, which is not considered while printing errors by the "higher > levels". An option could be to print the error, but not when you > perform tuning. > > No big deal though, just a thought. Right, I could potentially put the driver into "tuning" mode and then suppress the errors during that time. If you request it I will do that. I will also note that there are many other error conditions in the driver that don't have such printouts. I think the general philosophy of this driver is not to print them... -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/