Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161039AbaDWRgh (ORCPT ); Wed, 23 Apr 2014 13:36:37 -0400 Received: from top.free-electrons.com ([176.31.233.9]:59931 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1161002AbaDWRge (ORCPT ); Wed, 23 Apr 2014 13:36:34 -0400 Date: Wed, 23 Apr 2014 19:36:31 +0200 From: Antoine =?iso-8859-1?Q?T=E9nart?= To: Sebastian Hesselbarth Cc: zmxu@marvell.com, jszhang@marvell.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alexandre.belloni@free-electrons.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/2] ARM: dts: berlin: enable SD card reader and eMMC for the BG2Q DMP Message-ID: <20140423173631.GA10464@kwain> References: <1398155248-1659-1-git-send-email-antoine.tenart@free-electrons.com> <1398155248-1659-3-git-send-email-antoine.tenart@free-electrons.com> <5357F7BF.8000703@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5357F7BF.8000703@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sebastian, On Wed, Apr 23, 2014 at 07:26:23PM +0200, Sebastian Hesselbarth wrote: > On 04/22/2014 10:27 AM, Antoine T?nart wrote: > > Enable the SD Card reader and the internal eMMC on the Berlin BG2Q DMP > > using two of the SDHCI nodes of the Berlin BG2Q. > > > > Signed-off-by: Antoine T?nart > > --- > > arch/arm/boot/dts/berlin2q-marvell-dmp.dts | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts b/arch/arm/boot/dts/berlin2q-marvell-dmp.dts > > index 2da9c41e29d8..6ca8c9e52b08 100644 > > --- a/arch/arm/boot/dts/berlin2q-marvell-dmp.dts > > +++ b/arch/arm/boot/dts/berlin2q-marvell-dmp.dts > > @@ -26,3 +26,14 @@ > > &uart0 { > > status = "okay"; > > }; > > + > > +&sdhci1 { > > Antoine, > > nit: please sort referenced nodes alphabetically. > > With your comments about mmc aliases, I can take both patches > in now (and fixup ordering) if you like. You can take them. I talked with Jisheng about this and the plan is to make a following up series for the aliases since it will require to modify the subsystem. Thanks! Antoine > > Sebastian > > > + broken-cd; > > + sdhci,wp-inverted; > > + status = "okay"; > > +}; > > + > > +&sdhci2 { > > + non-removable; > > + status = "okay"; > > +}; > > > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Antoine T?nart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/