Date: Wed, 23 Apr 2014 14:59:26 -0400 (EDT)
Message-Id: <20140423.145926.998744821096383568.davem@davemloft.net>
To: hchaumette@adeneo-embedded.com
Cc: f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        trivial@kernel.org
Subject: Re: [PATCH] net/phy: micrel: fix bugged test on device tree
 loading for ksz9021
From: David Miller <davem@davemloft.net>
In-Reply-To: <1398171664-32662-1-git-send-email-hchaumette@adeneo-embedded.com>
References: <1398171664-32662-1-git-send-email-hchaumette@adeneo-embedded.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

From: Hubert Chaumette <hchaumette@adeneo-embedded.com>
Date: Tue, 22 Apr 2014 15:01:04 +0200

> In ksz9021_load_values_from_of() val2 to val4 aren't tested against their
> initialization value.
> This causes the test to always succeed, and this value to be used as if it
> was loaded from the devicetree instead of being ignored, in case of a
> missing/invalid property in the ethernet OF device node.
> As a result, the value "0" is written to the relevant registers.
> 
> Change the conditions to test against the right initialization value.
> 
> Signed-off-by: Hubert Chaumette <hchaumette@adeneo-embedded.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/