Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758029AbaDWUAZ (ORCPT ); Wed, 23 Apr 2014 16:00:25 -0400 Received: from mga09.intel.com ([134.134.136.24]:25758 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756214AbaDWUAX (ORCPT ); Wed, 23 Apr 2014 16:00:23 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,913,1389772800"; d="scan'208";a="498331345" Date: Wed, 23 Apr 2014 13:00:22 -0700 From: Andi Kleen To: Venkatesh Srinivas Cc: Borislav Petkov , Stephane Eranian , Linux Kernel Developers List , Peter Zijlstra , mingo@elte.hu, zheng.z.yan@intel.com Subject: Re: [PATCH] perf/x86: fix RAPL rdmsrl_safe() usage Message-ID: <20140423200022.GJ8874@tassilo.jf.intel.com> References: <20140423170418.GA12767@quad> <20140423190015.GF25378@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Acked-by: Borislav Petkov > > Brown-Paper-Bag-Worn-By: Venkatesh Srinivas Again the bug is really in KVM. We wouldn't need all this crap if KVM didn't throw the bogus #GPs. I'm sure you missed plenty of MSR accesses elsewhere, and it's a ticking time bomb. If the VM lies to the kernel with the family-model you need to at least limit the consequences. KVM is spectacularly failing to do that by throwing bogus #GPs. The brown paper bad needs to be employed on the KVM code (or better the bug be fixed there, by defaulting to not #GP on unknown MSRs) -Andi -- ak@linux.intel.com -- Speaking for myself only -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/