Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755507AbaDXJU6 (ORCPT ); Thu, 24 Apr 2014 05:20:58 -0400 Received: from mail-qc0-f181.google.com ([209.85.216.181]:41149 "EHLO mail-qc0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755440AbaDXJUy (ORCPT ); Thu, 24 Apr 2014 05:20:54 -0400 MIME-Version: 1.0 In-Reply-To: References: <1398210681-22976-1-git-send-email-dianders@chromium.org> Date: Thu, 24 Apr 2014 11:14:51 +0200 Message-ID: Subject: Re: [PATCH] mmc: dw_mmc: Don't print data errors From: Ulf Hansson To: Doug Anderson Cc: Seungwon Jeon , Jaehoon Chung , Yuvaraj Kumar C D , Alim Akhtar , Sonny Rao , linux-samsung-soc , Chris Ball , linux-mmc , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> The "status" here could be useful information about the status >> register, which is not considered while printing errors by the "higher >> levels". An option could be to print the error, but not when you >> perform tuning. >> >> No big deal though, just a thought. > > Right, I could potentially put the driver into "tuning" mode and then > suppress the errors during that time. If you request it I will do > that. > > I will also note that there are many other error conditions in the > driver that don't have such printouts. I think the general philosophy > of this driver is not to print them... So, then let's stick to that philosophy and keep this as is. Kind regards Ulf Hansson > > -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/