Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755236AbaDXJal (ORCPT ); Thu, 24 Apr 2014 05:30:41 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:50863 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754988AbaDXJaf (ORCPT ); Thu, 24 Apr 2014 05:30:35 -0400 MIME-Version: 1.0 In-Reply-To: <201404240924.s3O9OYCC021688@toshiba.co.jp> References: <201404240725.s3O7PrUv003720@toshiba.co.jp> <201404240832.s3O8WHd0011014@toshiba.co.jp> <201404240924.s3O9OYCC021688@toshiba.co.jp> Date: Thu, 24 Apr 2014 15:00:34 +0530 Message-ID: Subject: Re: [RFC 0/4] Migrate timers away from cpuset on setting cpuset.quiesce From: Viresh Kumar To: Daniel Sangorrin Cc: Thomas Gleixner , =?UTF-8?B?RnLDqWTDqXJpYyBXZWlzYmVja2Vy?= , Peter Zijlstra , Ingo Molnar , Tejun Heo , Li Zefan , Lists linaro-kernel , Linux Kernel Mailing List , Cgroups Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24 April 2014 14:54, Daniel Sangorrin wrote: > Why didn't you just apply the patch on top of your tree so that the > information included in the git commit (e.g: my name and mail) remains? > > This part: > > cpuset: quiesce: change irq disable/enable by irq save/restore > > The function __migrate_timers can be called under interrupt context > or thread context depending on the core where the system call was > executed. In case it executes under interrupt context, it > seems a bad idea to leave interrupts enabled after migrating the > timers. In fact, this caused kernel errors on the ARM architecture and > on the x86_64 architecture with the 3.10 kernel (backported version > of the cpuset-quiesce patch). > > Signed-off-by: Daniel Sangorrin > Signed-off-by: Yoshitake Kobayashi That's what I told you earlier when I said this: > I can't keep it as a separate patch and so would be required to merge > it into my original patch.. And the reason being: "No patch is supposed to break things, otherwise git bisect wouldn't work smoothly".. And so git bisect would complain this issue after my patch and so I have to merge the fixes you gave into the original patch as its not yet merged. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/