Date: Thu, 24 Apr 2014 13:27:15 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: "Yan, Zheng" <zheng.z.yan@intel.com>, Ingo Molnar <mingo@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Arnaldo Carvalho de Melo <acme@infradead.org>,
        Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH v2 4/4] perf/x86/uncore: modularize Intel uncore driver
Message-ID: <20140424112715.GQ11096@twins.programming.kicks-ass.net>
References: <1395295426-12391-1-git-send-email-zheng.z.yan@intel.com>
 <20140418105354.GA29167@gmail.com>
 <53548008.3040504@intel.com>
 <20140422113545.GA14950@gmail.com>
 <CABPqkBTHv3U6L4fKOvsFcaWR8HcOEaqGGxRMRn-+O68a0BLCuA@mail.gmail.com>
 <20140424081408.GA7709@gmail.com>
 <5358E6A2.3020505@intel.com>
 <CABPqkBRihMr=+X_Gb5dSYfForTpGA6XZGfTHOA3PZNAHTJDPkg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CABPqkBRihMr=+X_Gb5dSYfForTpGA6XZGfTHOA3PZNAHTJDPkg@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org

On Thu, Apr 24, 2014 at 12:36:01PM +0200, Stephane Eranian wrote:
> > Most of hardware specific codes in the Intel uncore driver are for
> > SandyBridge/IvyBridge/Haswell. Uncore subsystem in these CPUs are
> > similar. One module per CPU type means we have to duplicate lots of
> > code. I don't think it's a good idea.
> >
> Then, at least split nhm_ex from the rest. It is very big.

Aren't the EX parts in general far more complex and different from the
EP parts? Or will the SNB/IVB/HSW-EX parts also be similar again? (this
would be a good thing).

But yes, it makes sense to at least split the EP and EX parts, and split
where the families are different.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/