Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758214AbaDXPhW (ORCPT ); Thu, 24 Apr 2014 11:37:22 -0400 Received: from mail-qc0-f179.google.com ([209.85.216.179]:47021 "EHLO mail-qc0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757903AbaDXPhU (ORCPT ); Thu, 24 Apr 2014 11:37:20 -0400 Date: Thu, 24 Apr 2014 11:37:16 -0400 From: Tejun Heo To: Frederic Weisbecker Cc: LKML , Christoph Lameter , Kevin Hilman , Lai Jiangshan , Mike Galbraith , "Paul E. McKenney" , Viresh Kumar Subject: Re: [PATCH 1/4] workqueue: Create low-level unbound workqueues cpumask Message-ID: <20140424153716.GG14460@htj.dyndns.org> References: <1398350256-7834-1-git-send-email-fweisbec@gmail.com> <1398350256-7834-2-git-send-email-fweisbec@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1398350256-7834-2-git-send-email-fweisbec@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 24, 2014 at 04:37:33PM +0200, Frederic Weisbecker wrote: > Create a cpumask that limit the affinity of all unbound workqueues. > This cpumask is controlled though a file at the root of the workqueue > sysfs directory. > > It works on a lower-level than the per WQ_SYSFS workqueues cpumask files > such that the effective cpumask applied for a given unbound workqueue is > the intersection of /sys/devices/virtual/workqueue/$WORKQUEUE/cpumask and > the new /sys/devices/virtual/workqueue/cpumask_unbounds file. Let's drop "_unbounds" postfix and name it just "cpumask". We don't apply it to per-cpu workqueues now but that really is an implementation detail and later when (and if) we actually distinguish per-cpu usages for correctness from for optimization, we may as well apply the same cpumask to per-cpu ones too. Another thing with naming is that I didn't anticipate having attributes at the top directory so the workqueue directories aren't namespaced. Maybe we want to namespace top level knobs? "system_cpumask" maybe? Any better ideas? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/