Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754006AbaDXVm4 (ORCPT ); Thu, 24 Apr 2014 17:42:56 -0400 Received: from mail-ob0-f177.google.com ([209.85.214.177]:41733 "EHLO mail-ob0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751203AbaDXVmy (ORCPT ); Thu, 24 Apr 2014 17:42:54 -0400 MIME-Version: 1.0 In-Reply-To: References: <1397847510-17199-1-git-send-email-tim.kryger@linaro.org> Date: Thu, 24 Apr 2014 14:42:54 -0700 Message-ID: Subject: Re: [PATCH] mmc: core: Try other signal levels during power up From: Tim Kryger To: Ulf Hansson Cc: Chris Ball , Linux MMC , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 24, 2014 at 1:38 AM, Ulf Hansson wrote: > On 18 April 2014 20:58, Tim Kryger wrote: >> void mmc_power_up(struct mmc_host *host, u32 ocr) >> { >> + int err; >> + > > The variable err is not needed, since we don't plan on printing it nor > returning it. Please remove and handle the return code directly in the > if statements. Sure. I'll send out an updated version shortly. Thanks, Tim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/