Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751075AbaDYAwy (ORCPT ); Thu, 24 Apr 2014 20:52:54 -0400 Received: from mail-ve0-f173.google.com ([209.85.128.173]:65269 "EHLO mail-ve0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750719AbaDYAww (ORCPT ); Thu, 24 Apr 2014 20:52:52 -0400 MIME-Version: 1.0 In-Reply-To: <1396646870-29695-1-git-send-email-rabin@rab.in> References: <1396646870-29695-1-git-send-email-rabin@rab.in> Date: Thu, 24 Apr 2014 17:52:51 -0700 X-Google-Sender-Auth: BQDTl-XScYIkYD6hJ9XUL15-a-I Message-ID: Subject: Re: [PATCH 1/2] arm: fixmap: implement __set_fixmap() From: Doug Anderson To: Rabin Vincent Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Kees Cook , Laura Abbott , Jon Medhurst Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Rabin, On Fri, Apr 4, 2014 at 2:27 PM, Rabin Vincent wrote: > This is used from set_fixmap() and clear_fixmap() via > asm-generic/fixmap.h. > > Signed-off-by: Rabin Vincent > --- > Needs "arm: use generic fixmap.h", available in linux-next. > > arch/arm/include/asm/fixmap.h | 2 ++ > arch/arm/mm/mmu.c | 7 +++++++ > 2 files changed, 9 insertions(+) > > diff --git a/arch/arm/include/asm/fixmap.h b/arch/arm/include/asm/fixmap.h > index 68ea615..55ed076 100644 > --- a/arch/arm/include/asm/fixmap.h > +++ b/arch/arm/include/asm/fixmap.h > @@ -23,6 +23,8 @@ enum fixed_addresses { > __end_of_fixed_addresses > }; > > +void __set_fixmap(enum fixed_addresses idx, unsigned long phys, pgprot_t prot); nit: I think you should use phys_addr_t for the physical address, right? void __set_fixmap(enum fixed_addresses idx, phys_addr_t phys, pgprot_t prot); ...I'm no expert at fixmap, but otherwise this looks pretty reasonable to me. -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/