Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752442AbaDYIIy (ORCPT ); Fri, 25 Apr 2014 04:08:54 -0400 Received: from mail-qc0-f169.google.com ([209.85.216.169]:45207 "EHLO mail-qc0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752389AbaDYIIb (ORCPT ); Fri, 25 Apr 2014 04:08:31 -0400 MIME-Version: 1.0 In-Reply-To: <535A156F.6060004@linaro.org> References: <1396967803-28868-1-git-send-email-gautam.vivek@samsung.com> <1396967803-28868-2-git-send-email-gautam.vivek@samsung.com> <534BF28E.7040906@samsung.com> <535A156F.6060004@linaro.org> Date: Fri, 25 Apr 2014 13:38:30 +0530 X-Google-Sender-Auth: Qhr5BFmCGAl58i0q_CJ4Dwv7FYw Message-ID: Subject: Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver From: Vivek Gautam To: Tushar Behera Cc: Sylwester Nawrocki , Linux USB Mailing List , "linux-samsung-soc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , linux-doc@vger.kernel.org, kishon , Greg KH , Felipe Balbi , Kukjin Kim , Tomasz Figa , Kamil Debski , Jingoo Han Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Fri, Apr 25, 2014 at 1:27 PM, Tushar Behera wrote: > On 04/14/2014 08:07 PM, Sylwester Nawrocki wrote: >> On 08/04/14 16:36, Vivek Gautam wrote: >>> diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt b/Documentation/devicetree/bindings/phy/samsung-phy.txt >>> index 28f9edb..6d99ba9 100644 >>> --- a/Documentation/devicetree/bindings/phy/samsung-phy.txt >>> +++ b/Documentation/devicetree/bindings/phy/samsung-phy.txt >>> @@ -74,3 +74,45 @@ phy-consumer@12340000 { >>> >>> Refer to DT bindings documentation of particular PHY consumer devices for more >>> information about required PHYs and the way of specification. >>> + >>> +Samsung Exynos5 SoC series USB DRD PHY controller >>> +-------------------------------------------------- >>> + >>> +Required properties: >>> +- compatible : Should be set to one of the following supported values: >>> + - "samsung,exynos5250-usbdrd-phy" - for exynos5250 SoC, >>> + - "samsung,exynos5420-usbdrd-phy" - for exynos5420 SoC. >>> +- reg : Register offset and length of USB DRD PHY register set; >>> +- clocks: Clock IDs array as required by the controller >>> +- clock-names: names of clocks correseponding to IDs in the clock property; >>> + Required clocks: >>> + - phy: main PHY clock (same as USB DRD controller i.e. DWC3 IP clock), >>> + used for register access. >>> + - ref: PHY's reference clock (usually crystal clock), associated by >>> + phy name, used to determine bit values for clock settings >>> + register. >>> + Additional clock required for Exynos5420: >>> + - usb30_sclk_100m: Additional special clock used for PHY operation >>> + depicted as 'sclk_usbphy30' in CMU of Exynos5420. >>> +- samsung,syscon-phandle: phandle for syscon interface, which is used to >>> + control pmu registers for power isolation. >> >> Why to append "-phandle" to the property's name ? If this is for PMU >> perhaps make it more explicit and name it: samsung,pmu-syscon or >> samsung,pmureg ? >> > > There are already a couple of nodes (watchdog and sata) using > samsung,syscon-phandle. IMHO, we should keep only property string for > syscon node. Either we keep syscon-phandle here or change sata/watchdog > driver to use the modified property name. IMHO samsung,pmu-syscon make more sense rather than appending a '-phandle' to the property name. This is a 'phandle' and that is in fact understood, isn't it ? We can change in the watchdog, sata drivers to use use the modified name. I can send a patch for the same if we are OK with this, so that we maintain the consistency in the device tree. -- Best Regards Vivek Gautam Samsung R&D Institute, Bangalore India -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/