Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751402AbaDYIhS (ORCPT ); Fri, 25 Apr 2014 04:37:18 -0400 Received: from mail-oa0-f51.google.com ([209.85.219.51]:36622 "EHLO mail-oa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750719AbaDYIhO (ORCPT ); Fri, 25 Apr 2014 04:37:14 -0400 MIME-Version: 1.0 In-Reply-To: <20140425081804.10258.8324.stgit@srivatsabhat.in.ibm.com> References: <20140425081728.10258.63980.stgit@srivatsabhat.in.ibm.com> <20140425081804.10258.8324.stgit@srivatsabhat.in.ibm.com> Date: Fri, 25 Apr 2014 14:07:13 +0530 Message-ID: Subject: Re: [PATCH 1/3] cpufreq, longhaul: Fix double invocation of cpufreq_freq_transition_begin/end From: Viresh Kumar To: "Srivatsa S. Bhat" Cc: "Rafael J. Wysocki" , Meelis Roos , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25 April 2014 13:48, Srivatsa S. Bhat wrote: > diff --git a/drivers/cpufreq/longhaul.c b/drivers/cpufreq/longhaul.c > @@ -269,8 +269,6 @@ static void longhaul_setstate(struct cpufreq_policy *policy, This routine has this code as well: mult = mults[mults_index & 0x1f]; if (mult == -1) return; speed = calc_speed(mult); if ((speed > highest_speed) || (speed < lowest_speed)) return; And so it might return without changing frequency and that's why I left this driver earlier for this change.. So, please return -EINVAL from here.. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/