Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752151AbaDYKMN (ORCPT ); Fri, 25 Apr 2014 06:12:13 -0400 Received: from mail7.hitachi.co.jp ([133.145.228.42]:41946 "EHLO mail7.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751471AbaDYKMJ (ORCPT ); Fri, 25 Apr 2014 06:12:09 -0400 Message-ID: <535A34F1.3000106@hitachi.com> Date: Fri, 25 Apr 2014 19:12:01 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Ingo Molnar , Jason Baron Cc: linux-kernel@vger.kernel.org, Rusty Russell , Andi Kleen , Ananth N Mavinakayanahalli , Sandeepa Prabhu , Frederic Weisbecker , x86@kernel.org, Steven Rostedt , fche@redhat.com, mingo@redhat.com, Rob Landley , "H. Peter Anvin" , Thomas Gleixner , "David S. Miller" , systemtap@sourceware.org Subject: Re: [PATCH -tip v9 20/26] kprobes: Support blacklist functions in module References: <20140417081636.26341.87858.stgit@ltc230.yrl.intra.hitachi.co.jp> <20140417081856.26341.53535.stgit@ltc230.yrl.intra.hitachi.co.jp> <20140424085601.GA7768@gmail.com> <5358F458.1030300@hitachi.com> <20140425081951.GA24829@gmail.com> In-Reply-To: <20140425081951.GA24829@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (2014/04/25 17:19), Ingo Molnar wrote: > > * Masami Hiramatsu wrote: > >> (2014/04/24 17:56), Ingo Molnar wrote: >>>> diff --git a/include/linux/module.h b/include/linux/module.h >>>> index f520a76..2fdb673 100644 >>>> --- a/include/linux/module.h >>>> +++ b/include/linux/module.h >>>> @@ -16,6 +16,7 @@ >>>> #include >>>> #include >>>> #include >>>> +#include >>> >>> This include breaks the x86 build: >>> >>> CC arch/x86/kernel/jump_label.o >>> In file included from arch/x86/kernel/jump_label.c:14:0: >>> /fast/mingo/tip/arch/x86/include/asm/kprobes.h:35:12: error: conflicting types for ‘kprobe_opcode_t' typedef u8 kprobe_opcode_t; >>> [...] >> >> Hmm, this error seems very odd... and I don't see > > Needs 'make allnoconfig' or some similar .config combination. Ah, OK. I could reproduce it. And as far as I can see, this is jump_label's bug. jump_label.c includes asm/kprobes.h directly, but that header is for internal use. It has to include linux/kprobes.h instead. Moreover, it doesn't need kprobes.h anymore. I'll fix that by another patch. Thank you, -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Research Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/