Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753460AbaDYLzK (ORCPT ); Fri, 25 Apr 2014 07:55:10 -0400 Received: from gw-1.arm.linux.org.uk ([78.32.30.217]:50224 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752704AbaDYLzJ (ORCPT ); Fri, 25 Apr 2014 07:55:09 -0400 Date: Fri, 25 Apr 2014 12:54:13 +0100 From: Russell King - ARM Linux To: Linus Walleij Cc: Anders Berg , Arnd Bergmann , Olof Johansson , Mike Turquette , Mark Rutland , Dmitry Eremin-Solenikov , David Woodhouse , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 3/6] ARM: dts: Device tree for AXM55xx. Message-ID: <20140425115413.GL26756@n2100.arm.linux.org.uk> References: <2386bd1367aa44741979461358a72dec89608597.1398335771.git.anders.berg@lsi.com> <20140424174741.GA23444@swsaberg01> <20140425094343.GA3160@swsaberg01> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 25, 2014 at 01:50:25PM +0200, Linus Walleij wrote: > This means that you can only get a proper, working IRQ from the > first line on gpio0 right? All other IRQs will be ignored. > > I see no problem in augmenting the driver to handle this > if #irqs == 8, the big change needs to happen in drivers/amba/bus.c > that has no way to pass any more than two IRQs atm. > > I guess the best is to augment struct amba_device with a field > struct resource *resource and num_resources like platform_device > instead of the hard-coded single resource for iomem and two > hardcoded IRQ placeholders, so that an arbitrary amount of > resources can be added to an amba_device as well. But that > may be quite a lot of work. (Russell will know which direction to > take here.) I definitely don't want to go down that route - I believe that the resource arrays are more pain than they're really worth - it requires a great amount of support to make that stuff work (just look at the amount of code there is to search the arrays, create them, etc.) We already have support for up to 9 IRQs, so 8 for GPIOs is already catered for. -- FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly improving, and getting towards what was expected from it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/