Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752775AbaDYNBc (ORCPT ); Fri, 25 Apr 2014 09:01:32 -0400 Received: from mail-vc0-f173.google.com ([209.85.220.173]:61735 "EHLO mail-vc0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751900AbaDYNAY (ORCPT ); Fri, 25 Apr 2014 09:00:24 -0400 MIME-Version: 1.0 In-Reply-To: <1398429171-8566-1-git-send-email-iivanov@mm-sol.com> References: <1398429171-8566-1-git-send-email-iivanov@mm-sol.com> Date: Fri, 25 Apr 2014 08:00:22 -0500 Message-ID: Subject: Re: [RFC PATCH] mfd: pm8x41: Naive function devices registration From: Rob Herring To: "Ivan T. Ivanov" Cc: Courtney Cavin , Josh Cartwright , Samuel Ortiz , Lee Jones , "linux-kernel@vger.kernel.org" , linux-arm-msm Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 25, 2014 at 7:32 AM, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > Currently functions that exist in both the controller at the > same address offset can not be specified with the same names. > > Adding Unique Slave ID device address to prefix function > device names fixes this. > > Function devices are SPMI devices, so register them on > SPMI bus. > > Signed-off-by: Ivan T. Ivanov > --- > drivers/mfd/pm8x41.c | 61 ++++++++++++++++++++++++++++++++++++++++++++++++---- No, this should be fixed in the core, not the driver. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/