Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752886AbaDYQHm (ORCPT ); Fri, 25 Apr 2014 12:07:42 -0400 Received: from p3plex2out04.prod.phx3.secureserver.net ([184.168.131.18]:42584 "EHLO p3plex2out04.prod.phx3.secureserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752158AbaDYQHk convert rfc822-to-8bit (ORCPT ); Fri, 25 Apr 2014 12:07:40 -0400 From: Hartley Sweeten To: Chase Southwood , "gregkh@linuxfoundation.org" CC: "abbotti@mev.co.uk" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 1/2] staging: comedi: addi_apci_1564: board does not have analog inputs Thread-Topic: [PATCH 1/2] staging: comedi: addi_apci_1564: board does not have analog inputs Thread-Index: AQHPYF7N3CbpMQXreUuD0ZnPm7U2+5sifs9A Date: Fri, 25 Apr 2014 16:07:38 +0000 Message-ID: References: <1398413826-19400-1-git-send-email-chase.southwood@gmail.com> In-Reply-To: <1398413826-19400-1-git-send-email-chase.southwood@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [184.183.19.121] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, April 25, 2014 1:17 AM, Chase Southwood wrote: > This board does not have analog inputs. Remove the subdevice init for > them. > > Signed-off-by: Chase Southwood > Cc: Ian Abbott > Cc: H Hartley Sweeten Looks good. Reviewed-by: H Hartley Sweeten As Ian mentioned, after you have removed the init for all the non-existent subdevices you should just get rid of them and only allocate the used ones. Thanks, Hartley -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/