Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753725AbaDYRXs (ORCPT ); Fri, 25 Apr 2014 13:23:48 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:48100 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751125AbaDYRXq (ORCPT ); Fri, 25 Apr 2014 13:23:46 -0400 Date: Fri, 25 Apr 2014 10:26:40 -0700 From: Greg KH To: jon@ringle.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, shc_work@mail.ru, Jon Ringle Subject: Re: [PATCH v7 1/2] serial: sc16is7xx Message-ID: <20140425172640.GA27841@kroah.com> References: <1398387367-4047-1-git-send-email-jon@ringle.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1398387367-4047-1-git-send-email-jon@ringle.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 24, 2014 at 08:56:06PM -0400, jon@ringle.org wrote: > From: Jon Ringle > > The SC16IS7xx is a slave I2C-bus/SPI interface to a single-channel > high performance UART. The SC16IS7xx's internal register set is > backward-compatible with the widely used and widely popular 16C450. > > The SC16IS7xx also provides additional advanced features such as > auto hardware and software flow control, automatic RS-485 support, and > software reset. > > Signed-off-by: Jon Ringle > --- > drivers/tty/serial/Kconfig | 9 + > drivers/tty/serial/Makefile | 1 + > drivers/tty/serial/sc16is7xx.c | 1279 ++++++++++++++++++++++++++++++++++++++ > include/uapi/linux/serial_core.h | 3 + > 4 files changed, 1292 insertions(+) > create mode 100644 drivers/tty/serial/sc16is7xx.c I get a few build warnings with this patch applied: drivers/tty/serial/sc16is7xx.c:1059:12: warning: ‘sc16is7xx_probe’ defined but not used [-Wunused-function] static int sc16is7xx_probe(struct device *dev, ^ drivers/tty/serial/sc16is7xx.c:1175:12: warning: ‘sc16is7xx_remove’ defined but not used [-Wunused-function] static int sc16is7xx_remove(struct device *dev) ^ drivers/tty/serial/sc16is7xx.c:1214:29: warning: ‘regcfg’ defined but not used [-Wunused-variable] static struct regmap_config regcfg = { ^ Can you send a follow-on patch to fix them? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/