Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754127AbaDYRkZ (ORCPT <rfc822;w@1wt.eu>);
	Fri, 25 Apr 2014 13:40:25 -0400
Received: from f179.i.mail.ru ([94.100.185.139]:55201 "EHLO f179.i.mail.ru"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751989AbaDYRkV (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 25 Apr 2014 13:40:21 -0400
X-Greylist: delayed 11209 seconds by postgrey-1.27 at vger.kernel.org; Fri, 25 Apr 2014 13:40:21 EDT
From: =?UTF-8?B?QWxleGFuZGVyIFNoaXlhbg==?= <shc_work@mail.ru>
To: =?UTF-8?B?R3JlZyBLSA==?= <gregkh@linuxfoundation.org>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        =?UTF-8?B?Sm9uIFJpbmdsZQ==?= <jringle@gridpoint.com>, jon@ringle.org
Subject: =?UTF-8?B?UmU6IFtQQVRDSCB2NyAxLzJdIHNlcmlhbDogc2MxNmlzN3h4?=
Mime-Version: 1.0
X-Mailer: Mail.Ru Mailer 1.0
X-Originating-IP: [5.18.98.0]
Date: Fri, 25 Apr 2014 21:40:18 +0400
Reply-To: =?UTF-8?B?QWxleGFuZGVyIFNoaXlhbg==?= <shc_work@mail.ru>
X-Priority: 3 (Normal)
Message-ID: <1398447618.26477952@f179.i.mail.ru>
Content-Type: text/plain; charset=utf-8
X-Mras: Ok
X-Spam: undefined
In-Reply-To: <20140425172640.GA27841@kroah.com>
References: <1398387367-4047-1-git-send-email-jon@ringle.org>
 <20140425172640.GA27841@kroah.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id s3PHeaWQ009322

Fri, 25 Apr 2014 10:26:40 -0700 от Greg KH <gregkh@linuxfoundation.org>:
> On Thu, Apr 24, 2014 at 08:56:06PM -0400, jon@ringle.org wrote:
> > From: Jon Ringle <jringle@gridpoint.com>
> > 
> > The SC16IS7xx is a slave I2C-bus/SPI interface to a single-channel
> > high performance UART. The SC16IS7xx's internal register set is
> > backward-compatible with the widely used and widely popular 16C450.
> > 
> > The SC16IS7xx also provides additional advanced features such as
> > auto hardware and software flow control, automatic RS-485 support, and
> > software reset.
> > 
> > Signed-off-by: Jon Ringle <jringle@gridpoint.com>
> > ---
> >  drivers/tty/serial/Kconfig       |    9 +
> >  drivers/tty/serial/Makefile      |    1 +
> >  drivers/tty/serial/sc16is7xx.c   | 1279 ++++++++++++++++++++++++++++++++++++++
> >  include/uapi/linux/serial_core.h |    3 +
> >  4 files changed, 1292 insertions(+)
> >  create mode 100644 drivers/tty/serial/sc16is7xx.c
> 
> I get a few build warnings with this patch applied:
> 
> drivers/tty/serial/sc16is7xx.c:1059:12: warning: ‘sc16is7xx_probe’ defined but not used [-Wunused-function]
>  static int sc16is7xx_probe(struct device *dev,
>             ^
> drivers/tty/serial/sc16is7xx.c:1175:12: warning: ‘sc16is7xx_remove’ defined but not used [-Wunused-function]
>  static int sc16is7xx_remove(struct device *dev)
>             ^
> drivers/tty/serial/sc16is7xx.c:1214:29: warning: ‘regcfg’ defined but not used [-Wunused-variable]
>  static struct regmap_config regcfg = {
>                              ^
> 
> Can you send a follow-on patch to fix them?

Seems this just should contain: "depends on I2C" in the Kconfig.

---

????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?