Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754596AbaDYULX (ORCPT ); Fri, 25 Apr 2014 16:11:23 -0400 Received: from mailrelay005.isp.belgacom.be ([195.238.6.171]:33095 "EHLO mailrelay005.isp.belgacom.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754479AbaDYULV (ORCPT ); Fri, 25 Apr 2014 16:11:21 -0400 X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AiIWANzAWlNXQASl/2dsb2JhbABZgwaCQKkSmXACAoETF3SCUxMcIxiBAiQTiEUBykKFWogbZIRAAQOOdooOAZJcgzM7gSw Date: Fri, 25 Apr 2014 22:13:22 +0200 From: Fabian Frederick To: linux-kernel Cc: "James E.J. Bottomley" , akpm Subject: [PATCH 1/1] drivers/scsi/sd.c: remove positive test on unsigned value Message-Id: <20140425221322.4ee6e11dac3be4d42f27fc88@skynet.be> X-Mailer: Sylpheed 3.3.0 (GTK+ 2.24.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org val is unsigned. Cc: "James E.J. Bottomley" Cc: Andrew Morton Signed-off-by: Fabian Frederick --- drivers/scsi/sd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index efcbcd1..b54d4f8 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -296,7 +296,7 @@ protection_type_store(struct device *dev, struct device_attribute *attr, if (err) return err; - if (val >= 0 && val <= SD_DIF_TYPE3_PROTECTION) + if (val <= SD_DIF_TYPE3_PROTECTION) sdkp->protection_type = val; return count; -- 1.8.4.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/