Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751716AbaDZNwB (ORCPT ); Sat, 26 Apr 2014 09:52:01 -0400 Received: from mail-oa0-f42.google.com ([209.85.219.42]:59637 "EHLO mail-oa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751552AbaDZNvW (ORCPT ); Sat, 26 Apr 2014 09:51:22 -0400 MIME-Version: 1.0 In-Reply-To: <535BAC3A.1010202@kernel.org> References: <1398420888-5506-1-git-send-email-ch.naveen@samsung.com> <1398420888-5506-2-git-send-email-ch.naveen@samsung.com> <535BAC3A.1010202@kernel.org> From: Naveen Krishna Ch Date: Sat, 26 Apr 2014 19:21:01 +0530 Message-ID: Subject: Re: [PATCH 1/5] iio: exynos_adc: use indio_dev->dev structure to handle child nodes To: Jonathan Cameron Cc: Doug Anderson , Naveen Krishna Chatradhi , linux-iio , "linux-kernel@vger.kernel.org" , linux-samsung-soc , Greg Kroah-Hartman , Lars-Peter Clausen , "cpgs ." , Grant Grundler Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Jonathan, On 26 April 2014 18:23, Jonathan Cameron wrote: > On 25/04/14 16:46, Doug Anderson wrote: >> >> Naveen, >> >> Thanks for sending this. Given that Jonathan Cameron was involved in >> the previous discussion, it probably would have been wise to include >> him on the CC list. > > In my case, don't worry too much as I have linux-iio coming into exactly > the same place in my inbox. Doug is correct that it is generally a good > idea unless someone has asked you not to. Sure, will make it a habit. > >> >> On Fri, Apr 25, 2014 at 3:14 AM, Naveen Krishna Chatradhi >> wrote: >>> >>> From: Naveen Krishna Ch >>> >>> Using pdev->dev with device_for_each_child() would iterate over all >>> of the children of the platform device and delete them. >>> Thus, causing crashes during module unload. >>> >>> We should be using the indio_dev->dev structure for >>> registering/unregistering child nodes. >>> >>> Signed-off-by: Naveen Krishna Ch >>> --- >>> This change was tested on top of >>> https://lkml.org/lkml/2014/4/21/481 from Doug. >>> >>> drivers/iio/adc/exynos_adc.c | 6 +++--- >>> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> >> Reported-by: Doug Anderson >> Reviewed-by: Doug Anderson >> Tested-by: Doug Anderson > > Applied to the fixes-togreg branch of iio.git I've submitted the v2. Kindly, review the other 4 patches in this series. Thanks > > Thanks. >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-iio" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > -- Shine bright, (: Nav :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/