Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752718AbaD0A36 (ORCPT ); Sat, 26 Apr 2014 20:29:58 -0400 Received: from mail-we0-f182.google.com ([74.125.82.182]:39863 "EHLO mail-we0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752607AbaD0A34 (ORCPT ); Sat, 26 Apr 2014 20:29:56 -0400 From: Javier Martinez Canillas To: Julia Lawall Cc: Gilles Muller , Nicolas Palix , Michal Marek , cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org, Javier Martinez Canillas Subject: [PATCH 1/1] scripts/coccinelle: use BIT() macro if possible Date: Sun, 27 Apr 2014 02:29:46 +0200 Message-Id: <1398558586-28931-1-git-send-email-javier@dowhile0.org> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Using the BIT() macro instead of manually shifting bits makes the code less error prone and also more readable. Signed-off-by: Javier Martinez Canillas --- An example of the patches that can be obtained with this spatch: http://www.mail-archive.com/linux-gpio@vger.kernel.org/msg02722.html scripts/coccinelle/api/bit.cocci | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 scripts/coccinelle/api/bit.cocci diff --git a/scripts/coccinelle/api/bit.cocci b/scripts/coccinelle/api/bit.cocci new file mode 100644 index 0000000..a5df73a --- /dev/null +++ b/scripts/coccinelle/api/bit.cocci @@ -0,0 +1,25 @@ +// Use the macro BIT() macro if possible +// +// Confidence: High +// Copyright (C) 2014 Javier Martinez Canillas. GPLv2. +// URL: http://coccinelle.lip6.fr/ +// Options: --include-headers + +@hasbitops@ +@@ + +#include + +@depends on hasbitops@ +expression E; +@@ + +- 1 << E ++ BIT(E) + +@depends on hasbitops@ +expression E; +@@ + +- BIT((E)) ++ BIT(E) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/