Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753962AbaD0Klr (ORCPT ); Sun, 27 Apr 2014 06:41:47 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:52977 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752849AbaD0Klq (ORCPT ); Sun, 27 Apr 2014 06:41:46 -0400 MIME-Version: 1.0 X-Originating-IP: [95.23.103.39] In-Reply-To: References: <1398558586-28931-1-git-send-email-javier@dowhile0.org> Date: Sun, 27 Apr 2014 12:41:45 +0200 Message-ID: Subject: Re: [PATCH 1/1] scripts/coccinelle: use BIT() macro if possible From: Javier Martinez Canillas To: Julia Lawall Cc: Gilles Muller , Nicolas Palix , Michal Marek , Coccinelle , Linux Kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 27, 2014 at 12:29 PM, Julia Lawall wrote: > > > On Sun, 27 Apr 2014, Javier Martinez Canillas wrote: > >> Using the BIT() macro instead of manually shifting bits >> makes the code less error prone and also more readable. >> >> Signed-off-by: Javier Martinez Canillas >> --- >> >> An example of the patches that can be obtained with this spatch: >> >> http://www.mail-archive.com/linux-gpio@vger.kernel.org/msg02722.html >> >> scripts/coccinelle/api/bit.cocci | 25 +++++++++++++++++++++++++ >> 1 file changed, 25 insertions(+) >> create mode 100644 scripts/coccinelle/api/bit.cocci >> >> diff --git a/scripts/coccinelle/api/bit.cocci b/scripts/coccinelle/api/bit.cocci >> new file mode 100644 >> index 0000000..a5df73a >> --- /dev/null >> +++ b/scripts/coccinelle/api/bit.cocci >> @@ -0,0 +1,25 @@ >> +// Use the macro BIT() macro if possible >> +// >> +// Confidence: High >> +// Copyright (C) 2014 Javier Martinez Canillas. GPLv2. >> +// URL: http://coccinelle.lip6.fr/ >> +// Options: --include-headers >> + >> +@hasbitops@ >> +@@ >> + >> +#include > > Here you could say: > > @usesbit@ > @@ > BIT(...) > > >> +@depends on hasbitops@ > > and then here it would be > > @depends on hasbitops && usesbit@ > > julia > Thanks a lot for the feedback, I'll send a v2 of the patch then. Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/