Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752042AbaD0VRO (ORCPT ); Sun, 27 Apr 2014 17:17:14 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:52876 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751307AbaD0VRM (ORCPT ); Sun, 27 Apr 2014 17:17:12 -0400 From: "Rafael J. Wysocki" To: Lv Zheng Cc: "Rafael J. Wysocki" , Len Brown , Lv Zheng , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v2 1/5] ACPICA: OSL: Add direct inclusion of extra header. Date: Sun, 27 Apr 2014 23:33:38 +0200 Message-ID: <3997362.yjEHqV8nv6@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.14.0-rc7+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <43884d194fd55ca9124078d3374ec4cf4a8026ef.1398232408.git.lv.zheng@intel.com> References: <43884d194fd55ca9124078d3374ec4cf4a8026ef.1398232408.git.lv.zheng@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, April 23, 2014 02:53:52 PM Lv Zheng wrote: > This is a linuxized result of an ACPICA commit to upgrade the extra > header mechanism. > > This patch enhances the extra header solution to allow Linux to use > ACPI_USE_NATIVE_INTERFACE_HEADER and the file name can be automatically > replaced during ACPICA release process. Using this way, the rest of the > ACPICA users needn't know the name of the extra header file. Lv Zheng. > > Signed-off-by: Lv Zheng > --- > include/acpi/acpi.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/acpi/acpi.h b/include/acpi/acpi.h > index ca0cb60..682398b 100644 > --- a/include/acpi/acpi.h > +++ b/include/acpi/acpi.h > @@ -62,8 +62,8 @@ > #include /* Resource Descriptor structs */ > #include /* OSL interfaces (ACPICA-to-OS) */ > #include /* ACPI core subsystem external interfaces */ > -#ifdef ACPI_NATIVE_INTERFACE_HEADER > -#include ACPI_NATIVE_INTERFACE_HEADER > +#ifdef ACPI_USE_NATIVE_INTERFACE_HEADER > +#include > #endif > > #endif /* __ACPI_H__ */ Well, I still think there's a better way. Introduce into ACPICA and put this into it: #if defined(_LINUX) || defined(__linux__) #include #endif and then move stuff you want in acpi/acpi_opt.h into acpi/platform/aclinuxex.h. Then, you'll have in acpi.h: #include /* Resource Descriptor structs */ #include /* OSL interfaces (ACPICA-to-OS) */ #include /* ACPI core subsystem external interfaces */ #include /* Extra environment-specific items */ That should work I suppose, shouldn't it? -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/