Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751677AbaD0WWw (ORCPT ); Sun, 27 Apr 2014 18:22:52 -0400 Received: from smtprelay04.ispgateway.de ([80.67.29.8]:57695 "EHLO smtprelay04.ispgateway.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750724AbaD0WWv (ORCPT ); Sun, 27 Apr 2014 18:22:51 -0400 References: <1398561815-22033-1-git-send-email-peter@piie.net> <1398561815-22033-2-git-send-email-peter@piie.net> <20140427210321.GA16142@pd.tnic> Message-ID: X-Mailer: http://www.courier-mta.org/cone/ From: Peter Feuerer To: Borislav Petkov Cc: LKML , Andreas Mohr Subject: Re: [PATCH 1/4] acerhdf: Adding support for =?UTF-8?B?Im1hbnVhbCBtb2RlIg==?= Date: Mon, 28 Apr 2014 00:22:47 +0200 Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset="US-ASCII" Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Df-Sender: NDA0MDk0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Borislav Petkov writes: > On Sun, Apr 27, 2014 at 03:23:32AM +0200, Peter Feuerer wrote: >> From: Peter Feuerer >> >> Some Acer models require an additional command to turn off the fan after >> bios mode has been enabled. Adding new section in bios table to allow >> support for those models, by writing an extra "manual mode" register. > > Why? > > That command is always the same AFAICT. So why not add a single flag to > bios_settings_t called "needs_manual" or such and then do the required > dance in acerhdf_change_fanstate() if it is set? I wanted to be prepared for possible upcoming models with changed registers / values. But I guess it would make sense to go for your proposal for now and then afterwards we should discuss about implementing the idea of Andreas and split the bios_tbl. > Btw, this "struct bios_settings_t" could lose that "_t" at the end as it > is not a typedef. We don't like typedefs anyway. :-) True, will put this on my todo list :) -- --peter; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/