Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932160AbaD1CCQ (ORCPT ); Sun, 27 Apr 2014 22:02:16 -0400 Received: from [119.145.14.64] ([119.145.14.64]:42502 "EHLO szxga01-in.huawei.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1755084AbaD1CCL (ORCPT ); Sun, 27 Apr 2014 22:02:11 -0400 Message-ID: <535DB67A.2020108@huawei.com> Date: Mon, 28 Apr 2014 10:01:30 +0800 From: xiakaixu User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Namhyung Kim CC: , , Ingo Molnar , , Arnaldo Carvalho de Melo , Huxinwei , Genghui , , , Jiri Olsa , Borislav Petkov , Subject: Re: [PATCH] perf tools: Remove extra '/' character in events file path References: <535B6660.2060001@huawei.com> <87tx9epawt.fsf@sejong.aot.lge.com> In-Reply-To: <87tx9epawt.fsf@sejong.aot.lge.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.111.100.238] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 于 2014/4/28 8:14, Namhyung Kim 写道: > Hi xiakaixu, > > (Adding Jiri and Boris to CC) OK. thanks, > >> The array debugfs_known_mountpoints[] will cause extra '/' >> character output. >> Remove it. >> >> pre: >> $ perf probe -l >> /sys/kernel/debug//tracing/uprobe_events file does not exist - >> please rebuild kernel with CONFIG_UPROBE_EVENTS. >> >> post: >> $ perf probe -l >> /sys/kernel/debug/tracing/uprobe_events file does not exist - >> please rebuild kernel with CONFIG_UPROBE_EVENTS. > > Looks like all of its callers already provide a '/' after the debugfs > mountpoint, so > > Acked-by: Namhyung Kim > > Thanks, > Namhyung > >> >> Signed-off-by: Xia Kaixu >> --- >> tools/lib/api/fs/debugfs.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/tools/lib/api/fs/debugfs.c b/tools/lib/api/fs/debugfs.c >> index 7c43479..a74fba6 100644 >> --- a/tools/lib/api/fs/debugfs.c >> +++ b/tools/lib/api/fs/debugfs.c >> @@ -12,8 +12,8 @@ >> char debugfs_mountpoint[PATH_MAX + 1] = "/sys/kernel/debug"; >> >> static const char * const debugfs_known_mountpoints[] = { >> - "/sys/kernel/debug/", >> - "/debug/", >> + "/sys/kernel/debug", >> + "/debug", >> 0, >> }; >> >> -- 1.8.5.5 > . > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/