Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753278AbaD1ELK (ORCPT ); Mon, 28 Apr 2014 00:11:10 -0400 Received: from mga03.intel.com ([143.182.124.21]:10505 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752529AbaD1ELI (ORCPT ); Mon, 28 Apr 2014 00:11:08 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,941,1389772800"; d="scan'208";a="424697616" From: "Zheng, Lv" To: "Rafael J. Wysocki" CC: "Wysocki, Rafael J" , "Brown, Len" , Lv Zheng , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" Subject: RE: [PATCH v2 5/5] ACPICA: Remove deprecated _LINUX definitions for ACPICA. Thread-Topic: [PATCH v2 5/5] ACPICA: Remove deprecated _LINUX definitions for ACPICA. Thread-Index: AQHPYl7HvEJpVi0nxUqUK5Xuhp0dyJsmaDvA Date: Mon, 28 Apr 2014 04:10:57 +0000 Message-ID: <1AE640813FDE7649BE1B193DEA596E88025586A7@SHSMSX101.ccr.corp.intel.com> References: <8e6c90efc629b463709aef5da4957e916fdc0437.1398232409.git.lv.zheng@intel.com> <2215223.yYQsuKoaSF@vostro.rjw.lan> In-Reply-To: <2215223.yYQsuKoaSF@vostro.rjw.lan> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id s3S4BJgF020290 Hi, Rafael > From: Rafael J. Wysocki [mailto:rjw@rjwysocki.net] > Sent: Monday, April 28, 2014 5:39 AM > > On Wednesday, April 23, 2014 02:54:22 PM Lv Zheng wrote: > > There are _LINUX defined so that when Linux kernel is compiled using broken > > compilers that having not __linux__ defined can still include > > from . > > > > This behavior is deprecated as all drivers/acpi/acpica files are compiled > > without including , thus without _LINUX defined. As there is > > no issues encountered when we compile ACPICA code without _LINUX defined, > > it is OK to remove _LINUX from now. > > > > Signed-off-by: Lv Zheng > > --- > > include/linux/acpi.h | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/include/linux/acpi.h b/include/linux/acpi.h > > index 7a8f2cd..9c559f7 100644 > > --- a/include/linux/acpi.h > > +++ b/include/linux/acpi.h > > @@ -31,10 +31,6 @@ > > > > #ifdef CONFIG_ACPI > > > > -#ifndef _LINUX > > -#define _LINUX > > -#endif > > - > > #include > > #include > > What about ? Should it still check if _LINUX is defined > after this change? If you mean these lines: #if defined(_LINUX) || defined(__linux__) #include After deleting "_LINUX" from , acenv.h still can include aclinux.h because of "__linux__". Actually all drivers/acpi/acpica source files are compiled without including , so "_LINUX" defined in this file is useless to Linux. We needn't delete "_LINUX" from acenv.h. "_LINUX" is only used in ACPICA makefiles, Linux never uses it: https://github.com/acpica/acpica/blob/master/generate/unix/Makefile.config ACPICA can be compiled using the following make command: make HOST=_LINUX I think this is the only usage of "_LINUX" for now. Thanks and best regards -Lv > > > -- > I speak only for myself. > Rafael J. Wysocki, Intel Open Source Technology Center. ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?