Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753381AbaD1ENF (ORCPT ); Mon, 28 Apr 2014 00:13:05 -0400 Received: from mga01.intel.com ([192.55.52.88]:34877 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753315AbaD1ENB (ORCPT ); Mon, 28 Apr 2014 00:13:01 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,941,1389772800"; d="scan'208";a="522160882" From: "Zheng, Lv" To: "Rafael J. Wysocki" CC: "Wysocki, Rafael J" , "Brown, Len" , Lv Zheng , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" Subject: RE: [PATCH v2 1/5] ACPICA: OSL: Add direct inclusion of extra header. Thread-Topic: [PATCH v2 1/5] ACPICA: OSL: Add direct inclusion of extra header. Thread-Index: AQHPYl4Q+2XQuDtKtEK4uCbw6q01MpsmV8eg Date: Mon, 28 Apr 2014 04:12:44 +0000 Message-ID: <1AE640813FDE7649BE1B193DEA596E88025586C7@SHSMSX101.ccr.corp.intel.com> References: <43884d194fd55ca9124078d3374ec4cf4a8026ef.1398232408.git.lv.zheng@intel.com> <3997362.yjEHqV8nv6@vostro.rjw.lan> In-Reply-To: <3997362.yjEHqV8nv6@vostro.rjw.lan> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id s3S4DEBo020304 Hi, Rafael > From: Rafael J. Wysocki [mailto:rjw@rjwysocki.net] > Sent: Monday, April 28, 2014 5:34 AM > > On Wednesday, April 23, 2014 02:53:52 PM Lv Zheng wrote: > > This is a linuxized result of an ACPICA commit to upgrade the extra > > header mechanism. > > > > This patch enhances the extra header solution to allow Linux to use > > ACPI_USE_NATIVE_INTERFACE_HEADER and the file name can be automatically > > replaced during ACPICA release process. Using this way, the rest of the > > ACPICA users needn't know the name of the extra header file. Lv Zheng. > > > > Signed-off-by: Lv Zheng > > --- > > include/acpi/acpi.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/include/acpi/acpi.h b/include/acpi/acpi.h > > index ca0cb60..682398b 100644 > > --- a/include/acpi/acpi.h > > +++ b/include/acpi/acpi.h > > @@ -62,8 +62,8 @@ > > #include /* Resource Descriptor structs */ > > #include /* OSL interfaces (ACPICA-to-OS) */ > > #include /* ACPI core subsystem external interfaces */ > > -#ifdef ACPI_NATIVE_INTERFACE_HEADER > > -#include ACPI_NATIVE_INTERFACE_HEADER > > +#ifdef ACPI_USE_NATIVE_INTERFACE_HEADER > > +#include > > #endif > > > > #endif /* __ACPI_H__ */ > > Well, I still think there's a better way. > > Introduce into ACPICA and put this into it: > > #if defined(_LINUX) || defined(__linux__) > #include > > #endif > > and then move stuff you want in acpi/acpi_opt.h into acpi/platform/aclinuxex.h. > > Then, you'll have in acpi.h: > > #include /* Resource Descriptor structs */ > #include /* OSL interfaces (ACPICA-to-OS) */ > #include /* ACPI core subsystem external interfaces */ > #include /* Extra environment-specific items */ > > > That should work I suppose, shouldn't it? I think this should work. I'll modify this patch according the above suggestion. Thanks and best regards -Lv > -- > I speak only for myself. > Rafael J. Wysocki, Intel Open Source Technology Center. ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?