From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Dave Chinner <david@fromorbit.com>
Cc: agruen@kernel.org, bfields@fieldses.org, akpm@linux-foundation.org,
        viro@zeniv.linux.org.uk, dhowells@redhat.com,
        linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH -V1 00/22]  New ACL format for better NFSv4 acl interoperability
In-Reply-To: <20140427222019.GF15995@dastard>
References: <1398615293-22931-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <20140427222019.GF15995@dastard>
User-Agent: Notmuch/0.18~rc0+2~gbc64cdc (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu)
Date: Mon, 28 Apr 2014 10:54:52 +0530
Message-ID: <87zjj6auvv.fsf@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org

Dave Chinner <david@fromorbit.com> writes:

> On Sun, Apr 27, 2014 at 09:44:31PM +0530, Aneesh Kumar K.V wrote:
>> Hi
>> 
>> As per LSF/MM summit discussion I am reposting the richacl patchset for
>> upstream inclusion. The patchset includes minimal changes required to implement
>> a new acl model similar to NFSv4 ACL. The acl model selection is based on
>> file system feature flag. 
>> 
>> The following set of patches implements VFS and ext4 changes needed to implement
>> a new acl model for linux. Rich ACLs are an implementation of NFSv4 ACLs,
>> extended by file masks to fit into the standard POSIX file permission model.
>> They are designed to work seamlessly locally as well as across the NFSv4 and
>> CIFS/SMB2 network file system protocols.
>> 
>> A user-space utility for displaying and changing richacls is available at [1]
>> (a number of examples can be found at http://acl.bestbits.at/richacl/examples.html).
>> 
>> [1] git://github.com/kvaneesh/richacl-tools.git master
>> 
>> To test richacl on ext4, create the file sytem with richacl feature flag
>> (mkfs.ext4 -O richacl or  tune2fs -O richacl). With richacl feature enabled
>> using mount option "acl" will switch to using richacl instead of posixacl.
>
> No mount options, please. The ACL configuration needs to be
> determined solely by the superblock feature bit - we cannot support
> filesystems with mixed ACL types, and that's what this mount option
> does.

For ext4 since acls are enabled by default we really don't need to
speciy -o acl in mount. What i meant by above is that using "acl/noacl" mount
option will now enabe/disable POSIX or RICHacl based on the superblock
feature bit. 

>
>> More details regarding richacl can be found at
>> http://acl.bestbits.at/richacl/
>> 
>> Previous posting of the patchset can be found at:
>> http://mid.gmane.org/1319391835-5829-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com
>> "[PATCH -V8 00/26]  New ACL format for better NFSv4 acl interoperability"
>> 
>> The complete patchset can also be found at:
>> https://github.com/kvaneesh/linux/commits/richacl-for-upstream
>
> Where are the tests? We need comprehensive coverage in xfstests so
> we can validate that it works the way it is supposed to and that we
> don't break it in future, and that all filesystems behave the same
> way....
>

https://github.com/kvaneesh/richacl-tools/tree/master/test


-aneesh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/