Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755326AbaD1KcY (ORCPT ); Mon, 28 Apr 2014 06:32:24 -0400 Received: from e23smtp07.au.ibm.com ([202.81.31.140]:35241 "EHLO e23smtp07.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755098AbaD1KcX (ORCPT ); Mon, 28 Apr 2014 06:32:23 -0400 Message-ID: <535E2DC9.7080602@linux.vnet.ibm.com> Date: Mon, 28 Apr 2014 16:00:33 +0530 From: Anshuman Khandual User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Pedro Alves CC: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, avagin@openvz.org, oleg@redhat.com, mikey@neuling.org, benh@kernel.crashing.org Subject: Re: [PATCH 2/3] powerpc, ptrace: Add new ptrace request macros for transactional memory References: <1396422144-11032-1-git-send-email-khandual@linux.vnet.ibm.com> <1396422144-11032-3-git-send-email-khandual@linux.vnet.ibm.com> <535AF2E9.1000005@redhat.com> In-Reply-To: <535AF2E9.1000005@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14042810-0260-0000-0000-000004D81460 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/26/2014 05:12 AM, Pedro Alves wrote: > On 04/02/2014 08:02 AM, Anshuman Khandual wrote: >> This patch adds following new sets of ptrace request macros for transactional >> memory expanding the existing ptrace ABI on PowerPC. >> >> /* TM special purpose registers */ >> PTRACE_GETTM_SPRREGS >> PTRACE_SETTM_SPRREGS >> >> /* TM checkpointed GPR registers */ >> PTRACE_GETTM_CGPRREGS >> PTRACE_SETTM_CGPRREGS >> >> /* TM checkpointed FPR registers */ >> PTRACE_GETTM_CFPRREGS >> PTRACE_SETTM_CFPRREGS >> >> /* TM checkpointed VMX registers */ >> PTRACE_GETTM_CVMXREGS >> PTRACE_SETTM_CVMXREGS > > Urgh, we're _still_ adding specialized register specific calls? > Why aren't these exported as new register sets, accessible through > PTRACE_GETREGSET / PTRACE_SETREGSET? That's supposed to be the > Modern Way to do things. All these new register sets can be accessed through PTRACE_GETREGSET /SETREGSET requests with the new NT_PPC_* core note types added in the previous patch. PowerPC already has some register specific ptrace requests, so thought of adding some new requests for transactional memory purpose. But yes these are redundant and can be dropped. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/