Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756314AbaD1OLf (ORCPT ); Mon, 28 Apr 2014 10:11:35 -0400 Received: from mail-qc0-f178.google.com ([209.85.216.178]:60425 "EHLO mail-qc0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756299AbaD1OLb convert rfc822-to-8bit (ORCPT ); Mon, 28 Apr 2014 10:11:31 -0400 MIME-Version: 1.0 In-Reply-To: <20140428122918.GG21279@lee--X1> References: <1398670584-26687-1-git-send-email-micky_ching@realsil.com.cn> <20140428105350.GM21279@lee--X1> <20140428122918.GG21279@lee--X1> Date: Mon, 28 Apr 2014 16:11:30 +0200 Message-ID: Subject: Re: [PATCH] mmc: rtsx: Revert "mmc: rtsx: add support for pre_req and post_req" From: Ulf Hansson To: Lee Jones Cc: micky , Chris Ball , Samuel Ortiz , Greg Kroah-Hartman , Dan Carpenter , devel@linuxdriverproject.org, "linux-kernel@vger.kernel.org" , linux-mmc , Roger , Wei WANG Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28 April 2014 14:29, Lee Jones wrote: >> >> From: Micky Ching >> >> >> >> This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d. >> > >> > Why was this patch even merged without an MFD Ack? >> > >> >> commit did use >> >> mutex_unlock() in tasklet, but mutex_unlock() can't used in >> >> tasklet(atomic context). The driver need use mutex to avoid concurrency, >> >> so we can't use tasklet here, the patch need to be removed. >> >> >> >> The spinlock host->lock and pcr->lock may deadlock, one way to solve the >> >> deadlock is remove host->lock in sd_isr_done_transfer(), but if using >> >> workqueue the we can avoid using the spinlock and also avoid the problem. >> >> >> >> Signed-off-by: Micky Ching >> >> --- >> >> drivers/mfd/rtsx_pcr.c | 132 ++++-------- >> >> drivers/mmc/host/rtsx_pci_sdmmc.c | 418 ++++++------------------------------- >> >> include/linux/mfd/rtsx_common.h | 1 - >> >> include/linux/mfd/rtsx_pci.h | 6 - >> >> 4 files changed, 109 insertions(+), 448 deletions(-) >> > >> > This patch should be sent to the -rcs as soon as possible: >> >> Do you mind helping out doing it here Lee? Not sure how busy Chris is >> at the moment. > > I don't mind. I just need a maintainer Ack from one of you guys. Thanks for helping out Lee. Please hold on until we sorted out exactly what should be reverted, it seems like some additional patch should be removed/reverted as well. Kind regards Uffe > >> > >> > Acked-by: Lee Jones > > -- > Lee Jones > Linaro STMicroelectronics Landing Team Lead > Linaro.org │ Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/