Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932857AbaD1QCH (ORCPT ); Mon, 28 Apr 2014 12:02:07 -0400 Received: from top.free-electrons.com ([176.31.233.9]:49801 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756298AbaD1QCB (ORCPT ); Mon, 28 Apr 2014 12:02:01 -0400 Message-ID: <535E7B64.1040207@free-electrons.com> Date: Mon, 28 Apr 2014 18:01:40 +0200 From: Boris BREZILLON User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: =?ISO-8859-1?Q?Emilio_L=F3pez?= CC: Mike Turquette , Samuel Ortiz , Lee Jones , Chen-Yu Tsai , Maxime Ripard , Philipp Zabel , Shuge , kevin@allwinnertech.com, Hans de Goede , Randy Dunlap , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dev@linux-sunxi.org Subject: Re: [PATCH 5/7] clk: sunxi: add PRCM (Power/Reset/Clock Management) clks support References: <1398697130-8338-1-git-send-email-boris.brezillon@free-electrons.com> <1398697130-8338-6-git-send-email-boris.brezillon@free-electrons.com> <535E72D6.6060206@elopez.com.ar> In-Reply-To: <535E72D6.6060206@elopez.com.ar> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/04/2014 17:25, Emilio L?pez wrote: > Hi Boris, > > El 28/04/14 11:58, Boris BREZILLON escribi?: >> The PRCM (Power/Reset/Clock Management) unit provides several clock >> devices: >> - AR100 clk: used to clock the Power Management co-processor >> - AHB0 clk: used to clock the AHB0 bus >> - APB0 clk and gates: used to clk >> >> Add support for these clks in a separate driver so that they can be >> probed >> as platform devices instead of registered during early init. >> We need this to be able to probe PRCM MFD subdevices. >> >> Signed-off-by: Boris BREZILLON >> --- > (..) >> + >> +MODULE_AUTHOR("Boris BREZILLON > There's a missing > > >> +MODULE_DESCRIPTION("Allwinner Reset Controller Driver"); > > Copy/paste leftover? Thanks for catching those mistakes, I'll fix them. Best Regards, Boris > > >> +MODULE_LICENSE("GPL v2"); > > I just skimmed through this now, I'll have a more detailed look later. > Thanks for working on sun6i support :) > > Cheers, > > Emilio -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/