Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756770AbaD1QjH (ORCPT ); Mon, 28 Apr 2014 12:39:07 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:55723 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756580AbaD1QjA (ORCPT ); Mon, 28 Apr 2014 12:39:00 -0400 Message-ID: <535E8409.10905@ti.com> Date: Mon, 28 Apr 2014 11:38:33 -0500 From: Joel Fernandes User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: Sergei Shtylyov , Tony Lindgren , Benoit Cousson , Linux OMAP List , Linux ARM Kernel List , Linux Kernel Mailing List Subject: Re: [PATCH 07/10] ARM: dts: DRA7: Add DT node for DES IP References: <1398466968-29506-1-git-send-email-joelf@ti.com> <1398466968-29506-8-git-send-email-joelf@ti.com> <535BE096.2060407@cogentembedded.com> In-Reply-To: <535BE096.2060407@cogentembedded.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/26/2014 11:36 AM, Sergei Shtylyov wrote: > Hello. > > On 26-04-2014 3:02, Joel Fernandes wrote: > >> DRA7xx SoCs have a DES3DES IP. Add DT data for the same. > >> Signed-off-by: Joel Fernandes >> --- >> arch/arm/boot/dts/dra7.dtsi | 11 +++++++++++ >> 1 file changed, 11 insertions(+) > >> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi >> index 1c0f8e1..0533b89 100644 >> --- a/arch/arm/boot/dts/dra7.dtsi >> +++ b/arch/arm/boot/dts/dra7.dtsi >> @@ -789,6 +789,17 @@ >> dma-names = "tx0", "rx0"; >> status = "disabled"; >> }; >> + >> + des: des@480a5000 { > > Shouldn't the node name be "crypto@480a5000", according to the ePAPR > standard? > Actually I'm not a big fan of the standard here in this regard. "crypto@480a5000" doesn't mean anything and serves no purpose for anyone. There are quite a few crypto modules and such a name doesn't help and is confusing at best. There's no property either in the device tree node itself to describe it as des, except for the phandle label which is used only at dt compile-time if I'm right. So makes sense to have the name be more specific. This is how we have added dts nodes for other crypto modules in the past... thanks, -Joel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/