Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751745AbaD1TI2 (ORCPT ); Mon, 28 Apr 2014 15:08:28 -0400 Received: from fw-tnat.austin.arm.com ([217.140.110.23]:51734 "EHLO collaborate-mta1.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751601AbaD1TIY (ORCPT ); Mon, 28 Apr 2014 15:08:24 -0400 Message-ID: <1398707451.20390.14.camel@hornet> Subject: Re: [PATCH 1/3] driver core & of: Mark of_nodes of added device as populated From: Pawel Moll To: Rob Herring Cc: Mark Rutland , "devicetree@vger.kernel.org" , Mike Turquette , Samuel Ortiz , Arnd Bergmann , Ian Campbell , Dmitry Eremin-Solenikov , Greg Kroah-Hartman , Mark Brown , Liam Girdwood , Rob Herring , "linux-kernel@vger.kernel.org" , "arm@kernel.org" , Jean Delvare , Kumar Gala , Grant Likely , lm-sensors@lm-sensors.org, Lee Jones , David Woodhouse , Guenter Roeck , "linux-arm-kernel@lists.infradead.org" Date: Mon, 28 Apr 2014 18:50:51 +0100 In-Reply-To: <1398706660.20390.5.camel@hornet> References: <1392137610-27842-1-git-send-email-pawel.moll@arm.com> <1392137610-27842-2-git-send-email-pawel.moll@arm.com> <1398706660.20390.5.camel@hornet> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2014-04-28 at 18:37 +0100, Pawel Moll wrote: > On Thu, 2014-02-13 at 13:15 -0600, Rob Herring wrote: > > On Tue, Feb 11, 2014 at 10:53 AM, Pawel Moll wrote: > > > In "Device Tree powered" systems, platform devices are usually > > > massively populated with of_platform_populate() call, executed > > > at some level of initcalls, either by generic architecture > > > or by platform-specific code. > > > > Go read Grant's and my comments from your last posting. > > Right, I can't explain why I missed those. Will do right now. Actually I can't seem to find it in my mail archive, but I remember you were saying that it shouldn't spoil into the driver base code. You're probably right, so the updated patch will be limited to of_platform_* API. Grant was suggesting that I shouldn't be using the device model if I have to initialize some early stuff. The thing is that my stuff is not that early at all. The device model works for me perfectly, as long as I can initialize 3 crucial devices in a correct order (and *then* do mass population). And the init levels are perfect for this job. The only thing I need is a small refinement in the way DT-based devices are populated and this is exactly what I propose. Hope it makes more sense now. Cheers! Pawel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/