Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755486AbaD1V6J (ORCPT ); Mon, 28 Apr 2014 17:58:09 -0400 Received: from mail.mev.co.uk ([62.49.15.74]:47708 "EHLO mail.mev.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751993AbaD1V6H (ORCPT ); Mon, 28 Apr 2014 17:58:07 -0400 Message-ID: <535ECED3.9020205@mev.co.uk> Date: Mon, 28 Apr 2014 22:57:39 +0100 From: Ian Abbott Organization: MEV Ltd User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.4.0 MIME-Version: 1.0 To: Hartley Sweeten , Chase Southwood , "gregkh@linuxfoundation.org" CC: "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 3/6] staging: comedi: addi_apci_1032: board has 32 digital inputs References: <1398562558-5354-1-git-send-email-chase.southwood@gmail.com> <1398562623-5727-1-git-send-email-chase.southwood@gmail.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MEVEXCHANGE.mev.local (10.0.0.4) To MEVEXCHANGE.mev.local (10.0.0.4) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/04/14 19:11, Hartley Sweeten wrote: > On Saturday, April 26, 2014 6:37 PM, Chase Southwood wrote: >> This board always has 32 digital inputs. Remove the test when >> initializing the subdevice. >> >> Also, since this board is the only one supported by this driver, >> remove the boardinfo about the digital inputs and just use the >> data directly in the subdevice init. >> >> Signed-off-by: Chase Southwood >> Cc: Ian Abbott >> Cc: H Hartley Sweeten >> --- >> drivers/staging/comedi/drivers/addi_apci_1564.c | 26 +++++++++---------------- >> 1 file changed, 9 insertions(+), 17 deletions(-) > > Looks good. Apart from the subject not matching the patch! (I would have replied to the original, but I seem to have mislaid it.) -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/