Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755707AbaD1XYK (ORCPT ); Mon, 28 Apr 2014 19:24:10 -0400 Received: from mail-vc0-f175.google.com ([209.85.220.175]:52185 "EHLO mail-vc0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752090AbaD1XYI (ORCPT ); Mon, 28 Apr 2014 19:24:08 -0400 MIME-Version: 1.0 In-Reply-To: References: <1397859600-11507-1-git-send-email-robherring2@gmail.com> <1397859600-11507-4-git-send-email-robherring2@gmail.com> Date: Mon, 28 Apr 2014 18:24:07 -0500 Message-ID: Subject: Re: [PATCH v2 3/7] tty/serial: convert 8250 to generic earlycon From: Rob Herring To: Yinghai Lu Cc: "linux-arm-kernel@lists.infradead.org" , Linux Kernel Mailing List , "linux-serial@vger.kernel.org" , Greg Kroah-Hartman , Jiri Slaby , Catalin Marinas , Russell King , Will Deacon , Arnd Bergmann Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 26, 2014 at 1:29 AM, Yinghai Lu wrote: > On Fri, Apr 18, 2014 at 3:19 PM, Rob Herring wrote: >> From: Rob Herring >> >> With the generic earlycon infrastructure in place, convert the 8250 >> early console to use it. >> >> Signed-off-by: Rob Herring >> Cc: Greg Kroah-Hartman >> Cc: Jiri Slaby >> --- >> drivers/tty/serial/8250/8250_early.c | 138 ++++------------------------------- >> drivers/tty/serial/8250/Kconfig | 1 + >> 2 files changed, 16 insertions(+), 123 deletions(-) >> >> diff --git a/drivers/tty/serial/8250/8250_early.c b/drivers/tty/serial/8250/8250_early.c >> index c100d63..e83c9db 100644 >> --- a/drivers/tty/serial/8250/8250_early.c >> +++ b/drivers/tty/serial/8250/8250_early.c >> @@ -35,18 +35,8 @@ > ... >> - >> -int __init setup_early_serial8250_console(char *cmdline) > > You removed global function, but still left declaration and calling... > > arch/mips/mti-malta/malta-init.c: > setup_early_serial8250_console(console_string); > drivers/firmware/pcdp.c: return setup_early_serial8250_console(options); > include/linux/serial_8250.h:extern int > setup_early_serial8250_console(char *cmdline); Thanks for finding these. I missed them in my build tests. This should fix them: diff --git a/drivers/tty/serial/8250/8250_early.c b/drivers/tty/serial/8250/8250_early.c index e83c9db..2094c3b 100644 --- a/drivers/tty/serial/8250/8250_early.c +++ b/drivers/tty/serial/8250/8250_early.c @@ -156,6 +156,11 @@ static int __init early_serial8250_setup(struct earlycon_device *device, EARLYCON_DECLARE(uart8250, early_serial8250_setup); EARLYCON_DECLARE(uart, early_serial8250_setup); +int __init setup_early_serial8250_console(char *cmdline) +{ + return setup_earlycon(cmdline, "uart8250", early_serial8250_setup); +} + int serial8250_find_port_for_earlycon(void) { struct earlycon_device *device = early_device; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/