Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752739AbaD2Ctl (ORCPT ); Mon, 28 Apr 2014 22:49:41 -0400 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:25761 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750756AbaD2Ctk convert rfc822-to-8bit (ORCPT ); Mon, 28 Apr 2014 22:49:40 -0400 From: Xiangliang Yu To: James Bottomley CC: Jan Kasprzak , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Mon, 28 Apr 2014 19:49:29 -0700 Subject: RE: PATCH: mvsas: add support for Supermicro AOC-SAS2LP-MV8 Thread-Topic: PATCH: mvsas: add support for Supermicro AOC-SAS2LP-MV8 Thread-Index: Ac9jS3GK/Sj9aJq9Qwi8Lsk7betFEQACQKAg Message-ID: References: <20140428145201.GG29712@fi.muni.cz> <1398735385.2419.69.camel@dabdike.int.hansenpartnership.com> In-Reply-To: <1398735385.2419.69.camel@dabdike.int.hansenpartnership.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.11.96,1.0.14,0.0.0000 definitions=2014-04-29_01:2014-04-29,2014-04-28,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1402240000 definitions=main-1404290040 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Ben Hutchings already submitted a patch for this twice, which I cc'd you > on: > > http://marc.info/?t=139277203900003 > > will you ack it? PCI_VDEVICE() is a sort of take it or leave it macro. > It's not important and it will look untidy and a bit confusing having a > mix of open coding and macros, so I'd say convert all or none. > Using open coding because PCI_VENDOR_ID_MARVELL_EXT was undefined before. Now, we should use the macros instead of open coding. > > > > > Add support for the AOC-SAS2LP-MV8 SAS-2 controller from SuperMicro. > > > This controller has subdevice id 0x9485 instead of 0x9480, and apparently > > > this simple patch is the only thing needed to make it work. > > > > > > # lspci -vn > > > [...] > > > 03:00.0 0104: 1b4b:9485 (rev 03) > > > Subsystem: 1b4b:9485 > > > Flags: bus master, fast devsel, latency 0, IRQ 24 > > > Memory at feba0000 (64-bit, non-prefetchable) [size=128K] > > > Memory at febc0000 (64-bit, non-prefetchable) [size=256K] > > > Expansion ROM at feb90000 [disabled] [size=64K] > > > Capabilities: [40] Power Management version 3 > > > Capabilities: [50] MSI: Enable- Count=1/1 Maskable- 64bit+ > > > Capabilities: [70] Express Endpoint, MSI 00 > > > Capabilities: [100] Advanced Error Reporting > > > Capabilities: [140] Virtual Channel > > > Kernel driver in use: mvsas > > > Kernel modules: mvsas > > > > > > Signed-off-by: Jan Kasprzak > > > > > > diff --git a/drivers/scsi/mvsas/mv_init.c b/drivers/scsi/mvsas/mv_init.c > > > index 5ff978b..eacee48 100644 > > > --- a/drivers/scsi/mvsas/mv_init.c > > > +++ b/drivers/scsi/mvsas/mv_init.c > > > @@ -728,6 +728,15 @@ static struct pci_device_id mvs_pci_table[] = { > > > .class_mask = 0, > > > .driver_data = chip_9485, > > > }, > > > + { > > > + .vendor = PCI_VENDOR_ID_MARVELL_EXT, > > > + .device = 0x9485, > > > + .subvendor = PCI_ANY_ID, > > > + .subdevice = 0x9485, > > > + .class = 0, > > > + .class_mask = 0, > > > + .driver_data = chip_9485, > > > + }, > > > { PCI_VDEVICE(OCZ, 0x1021), chip_9485}, /* OCZ RevoDrive3 */ > > > { PCI_VDEVICE(OCZ, 0x1022), chip_9485}, /* OCZ RevoDrive3/zDriveR4 > (exact > > > model unknown) */ > > > { PCI_VDEVICE(OCZ, 0x1040), chip_9485}, /* OCZ RevoDrive3/zDriveR4 > (exact > > > model unknown) */ > > > > > > -- > > > | Jan "Yenya" Kasprzak > | > > > | New GPG 4096R/A45477D5 - see http://www.fi.muni.cz/~kas/pgp-rollover.txt > | > > > | http://www.fi.muni.cz/~kas/ Journal: > http://www.fi.muni.cz/~kas/blog/ > > > | > > > There's clearly a balance between "octopus merges are fine" and "Christ, > > > that's not an octopus, that's a Cthulhu merge". --Linus Torvalds > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/