From: Jingoo Han <jg1.han@samsung.com>
To: "'Jimmy Li'" <coder.liss@gmail.com>
Cc: "'Jonathan Cameron'" <jic23@kernel.org>,
        "'Greg Kroah-Hartman'" <gregkh@linuxfoundation.org>,
        "'Lars-Peter Clausen'" <lars@metafoo.de>,
        "'Sachin Kamat'" <sachin.kamat@linaro.org>,
        "'Monam Agarwal'" <monamagarwal123@gmail.com>,
        linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org, "'Jingoo Han'" <jg1.han@samsung.com>
References: <20140429055544.GA23599@gmail.com>
In-reply-to: <20140429055544.GA23599@gmail.com>
Subject: Re: [PATCH] staging:iio:ad2s1210 fix a leak when device removed
Date: Tue, 29 Apr 2014 15:07:04 +0900
Message-id: <001401cf6371$3e98cf90$bbca6eb0$%han@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
Content-transfer-encoding: 7bit
Thread-index: Ac9jb66rjj8ZWOU5Rn+UNP4LK1u3rAAAEGrw
Content-language: ko
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org

On Tuesday, April 29, 2014 2:56 PM, Jimmy Li wrote:
> 
> Signed-off-by: Jimmy Li <coder.liss@gmail.com>
> ---
>  drivers/staging/iio/resolver/ad2s1210.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c
> index 7fbaba4..3d6e123 100644
> --- a/drivers/staging/iio/resolver/ad2s1210.c
> +++ b/drivers/staging/iio/resolver/ad2s1210.c
> @@ -716,6 +716,7 @@ static int ad2s1210_remove(struct spi_device *spi)
> 
>  	iio_device_unregister(indio_dev);
>  	ad2s1210_free_gpios(iio_priv(indio_dev));
> +	devm_iio_device_free(&spi->dev, indio_dev);

NAK.

In ad2s1210_probe(),devm_iio_device_alloc() was already used.
So, when ad2s1210_remove() is called, iio_device_free() will
be called automatically. So, the leak never happens.

If you want to know about devm_* functions, please refer 
to the following.

  Documentation/driver-model/devres.txt

Best regards,
Jingoo Han
> 
>  	return 0;
>  }
> --
> 1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/