Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933607AbaD2KEw (ORCPT ); Tue, 29 Apr 2014 06:04:52 -0400 Received: from e28smtp03.in.ibm.com ([122.248.162.3]:53529 "EHLO e28smtp03.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933194AbaD2KEu (ORCPT ); Tue, 29 Apr 2014 06:04:50 -0400 Date: Tue, 29 Apr 2014 15:34:37 +0530 From: Srikar Dronamraju To: Oleg Nesterov Cc: Ingo Molnar , "H. Peter Anvin" , Ananth N Mavinakayanahalli , Anton Arapov , David Long , Denys Vlasenko , "Frank Ch. Eigler" , Jim Keniston , Jonathan Lebon , Masami Hiramatsu , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] uprobes/x86: Add uprobe_init_insn(), kill validate_insn_{32,64}bits() Message-ID: <20140429100437.GA3269@linux.vnet.ibm.com> Reply-To: Srikar Dronamraju References: <20140419170104.GA30667@redhat.com> <20140419170147.GA30850@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20140419170147.GA30850@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14042910-3864-0000-0000-00000DEEF689 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Oleg Nesterov [2014-04-19 19:01:47]: > validate_insn_32bits() and validate_insn_64bits() are very similar, > turn them into the single uprobe_init_insn() which has the additional > "bool x86_64" argument which can be passed to insn_init() and used to > choose between good_insns_64/good_insns_32. > > Also kill UPROBE_FIX_NONE, it has no users. > > Note: the current code doesn't use ifdef's consistently, good_insns_64 > depends on CONFIG_X86_64 but good_insns_32 is unconditional. This patch > removes ifdef around good_insns_64, we will add it back later along with > the similar one for good_insns_32. > > Signed-off-by: Oleg Nesterov Acked-by: Srikar Dronamraju -- Thanks and Regards Srikar Dronamraju -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/