Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933918AbaD2LjX (ORCPT ); Tue, 29 Apr 2014 07:39:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19551 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933540AbaD2LjW (ORCPT ); Tue, 29 Apr 2014 07:39:22 -0400 Date: Tue, 29 Apr 2014 13:38:54 +0200 From: Jiri Olsa To: Peter Zijlstra Cc: Namhyung Kim , Arnaldo Carvalho de Melo , Ingo Molnar , Stephane Eranian , LKML , Namhyung Kim Subject: Re: [PATCH v3 2/3] perf record: Propagate exit status of a command line workload Message-ID: <20140429113854.GE1148@krava.brq.redhat.com> References: <1398346054-3322-1-git-send-email-namhyung@kernel.org> <1398346054-3322-2-git-send-email-namhyung@kernel.org> <20140429105654.GB1148@krava.brq.redhat.com> <20140429111939.GP11096@twins.programming.kicks-ass.net> <20140429113304.GA13658@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140429113304.GA13658@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 29, 2014 at 01:33:04PM +0200, Peter Zijlstra wrote: > On Tue, Apr 29, 2014 at 01:19:39PM +0200, Peter Zijlstra wrote: > > On Tue, Apr 29, 2014 at 12:56:54PM +0200, Jiri Olsa wrote: > > > > > > perf_counter tools: Propagate signals properly > > > commit f7b7c26e01e51fe46097e11f179dc71ce7950084 > > > Author: Peter Zijlstra > > > Date: Wed Jun 10 15:55:59 2009 +0200 > > > > > > but I dont think we need to do that > > > > But but but, then you're re-introducing that fail again? That no good. > > The thing is, just the return value is not sufficient to determine if > the child was interrupted. > > See WAIT(2), things like WIFSIGNALED() will not work when you just > propagate the return value, you need to terminate the task with a > signal to propagate this. > cool, I just asked this in another email ;-) thanks jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/