Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757042AbaD2OOX (ORCPT ); Tue, 29 Apr 2014 10:14:23 -0400 Received: from mail-ee0-f42.google.com ([74.125.83.42]:62528 "EHLO mail-ee0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751400AbaD2OOV (ORCPT ); Tue, 29 Apr 2014 10:14:21 -0400 From: Grant Likely Subject: Re: [PATCH V7 1/1] drivers/gpio: Altera soft IP GPIO driver and devicetree binding To: Josh Cartwright , Tien Hock Loh Cc: robh+dt@kernel.org, pawel.moll@arm.com, Mark Rutland , ijc+devicetree@hellion.org.uk, Kumar Gala , Rob Landley , Linus Walleij , Alexandre Courbot , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, dinguyen@altera.com, "lftan@altera.com" In-Reply-To: <20140407171115.GA3956@joshc.qualcomm.com> References: <1393842463-5206-1-git-send-email-thloh@altera.com> <20140307151455.GI18529@joshc.qualcomm.com> <20140407171115.GA3956@joshc.qualcomm.com> Date: Tue, 29 Apr 2014 15:14:14 +0100 Message-Id: <20140429141414.BDD82C40992@trevor.secretlab.ca> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 7 Apr 2014 12:11:15 -0500, Josh Cartwright wrote: > On Mon, Apr 07, 2014 at 04:00:43PM +0800, Tien Hock Loh wrote: > > On Wed, Mar 19, 2014 at 6:09 PM, Tien Hock Loh wrote: > > > On Fri, Mar 7, 2014 at 11:14 PM, Josh Cartwright wrote: > > >> On Mon, Mar 03, 2014 at 06:27:43PM +0800, thloh@altera.com wrote: > > >>> From: Tien Hock Loh > [..] > > >>> + altera_gc->mapped_irq = irq_of_parse_and_map(node, 0); > > >>> > > >> > > >> platform_get_irq(pdev, 0); > > >> > > > OK. > > > > > > > platform_get_irq doesn't create the irq mapping which is needed by the > > driver. Since this driver is targeted at using of, should I be using > > irq_of_parse_and_map or should I still redo the codes with > > platform_get_irq and irq_create_mapping? I think the latter would be > > introducing code redundancy. Please advice. > > Yes, it is technically true that platform_get_irq() doesn't do the > mapping directly, but that's because the mapping is setup earlier, when > of_device_alloc() (drivers/of/platform.c) allocates resources for your > platform device. > > Calling irq_of_parse_and_map() should be unnecessary. In the latest mainline, platform_get_irq() now does the mapping when using an IRQ specified in the device tree. g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/