Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932794AbaD2OQS (ORCPT ); Tue, 29 Apr 2014 10:16:18 -0400 Received: from mailout2.w2.samsung.com ([211.189.100.12]:45294 "EHLO usmailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757467AbaD2OQQ (ORCPT ); Tue, 29 Apr 2014 10:16:16 -0400 X-AuditID: cbfec372-b7fe16d0000056bd-5c-535fb42fa132 Date: Tue, 29 Apr 2014 07:16:10 -0700 From: Mauro Carvalho Chehab To: Brian Healy Cc: Antti Palosaari , Linus Torvalds , Linux Kernel Mailing List , Linux Media Mailing List Subject: Re: [PATCH] Kernel 3.15-rc2 : Peak DVB-T USB tuner device ids for rtl28xxu driver Message-id: <20140429071610.63ccdfae.m.chehab@samsung.com> In-reply-to: <20140428214000.GA9187@gmail.com> References:

<20140428214000.GA9187@gmail.com> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.22; x86_64-redhat-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrALMWRmVeSWpSXmKPExsVy+t/hEF39LfHBBs++cFh8b37PZrHn9z5G i8u75rBZ9GzYymrxqO8tuwOrx85Zd9k9Dn9dyOJxYsZvFo/Pm+QCWKK4bFJSczLLUov07RK4 MuasO8dScEKsYtGavSwNjB1CXYycHBICJhI/vh1nhrDFJC7cW8/WxcjFISSwhFGi+/AcFgin mUni1OrpYFUsAqoSDdNbWUFsNgEjiVeNLWC2iICaxJJDrxhBGpgFTjFK3H/0A6ibg0NYIEbi 078UkBpeASuJXYveg9VzCuhJNJ/+CrVtL6NE/4MWRogznCRevZ7MBNEgKPFj8j0WEJtZQEti 87YmVghbXmLzmrfMExgFZiEpm4WkbBaSsgWMzKsYRUuLkwuKk9JzDfWKE3OLS/PS9ZLzczcx QkK5aAfjsw1WhxgFOBiVeHgP9MYFC7EmlhVX5h5ilOBgVhLh3bgpPliINyWxsiq1KD++qDQn tfgQIxMHp1QD4yq3OG9JJw2/aCGrvOhAk6p22faVy3+Ivl5070SBVuhhpk9b3GN+/Hguw9Ja f2v97+krrjbzzPY57vbWcJfmd9bml4XTpmpx21xblfa79a6rfuvJTV/DD/Edf/P5A0dgkV/k /nUPfx9IF6xU2pggeDei45y1K/PGRR3FAsmdN3/tFbiua21irsRSnJFoqMVcVJwIAHSywOVD AgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, 28 Apr 2014 22:40:00 +0100 Brian Healy escreveu: > From: Brian Healy > To: Antti Palosaari , Mauro Carvalho Chehab > Cc: Linus Torvalds , Linux Kernel Mailing List , Linux Media Mailing List > Subject: Re: [PATCH] Kernel 3.15-rc2 : Peak DVB-T USB tuner device ids for rtl28xxu driver > Date: Mon, 28 Apr 2014 22:40:00 +0100 > Sender: linux-media-owner@vger.kernel.org > User-Agent: Mutt/1.5.21 (2010-09-15) > > On Sun, Apr 27, 2014 at 03:19:12PM -0700, Linus Torvalds wrote: > > Hi Linus, > > apologies, i've changed email clients in order to preserve the > formatting this time around. The patch is now included inline as an > attachment. I ran the script but noticed you've already cc'd the > appropriate people. > > Brian. > > > Resubmitting modified patch. It's purpose is to add the appropriate > device/usb ids for the "Peak DVT-B usb dongle" to the rtl28xxu.c driver. > > Signed-off-by: Brian Healy gmail.com> > > > > Brian, please use > > > > ./scripts/get_maintainer -f drivers/media/usb/dvb-usb-v2/rtl28xxu.c > > > > to get the proper people to send this to, so that it doesn't get lost > > in the flood in lkml. > > > > The indentation of that new entry also seems to be suspect, in that it > > doesn't match the ones around it. > > > > Quoting full email for context for people added. > > > > Linus > > > > diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c > index 61d196e..b6e20cc 100644 > --- a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c > +++ b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c > @@ -1499,6 +1499,8 @@ static const struct usb_device_id rtl28xxu_id_table[] = { > &rtl2832u_props, "Crypto ReDi PC 50 A", NULL) }, > { DVB_USB_DEVICE(USB_VID_KYE, 0x707f, > &rtl2832u_props, "Genius TVGo DVB-T03", NULL) }, > + { DVB_USB_DEVICE(USB_VID_KWORLD_2, 0xd395, > + &rtl2832u_props, "Peak DVB-T USB", NULL) }, Patch is still a little odd, as you're using spaces for indenting, instead of tabs, but I can fix it with my scripts. Next time, please use tabs. Also, specifically in the case of patches for linux-media, you don't need to c/c me. Just send the patch to linux-media and to the driver maintainer (Antti, in this case). My workflow is to pick the patches from patchwork: https://patchwork.linuxtv.org/patch/23792/ after receiving Antti's ack. Alternatively, Antti may opt to put it on his git tree, sending it to me latter together of other patches he may have for the devices he maintains. > > /* RTL2832P devices: */ > { DVB_USB_DEVICE(USB_VID_HANFTEK, 0x0131, Thanks, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/