Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757924AbaD2OrP (ORCPT ); Tue, 29 Apr 2014 10:47:15 -0400 Received: from cantor2.suse.de ([195.135.220.15]:55515 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757424AbaD2OrN (ORCPT ); Tue, 29 Apr 2014 10:47:13 -0400 Date: Tue, 29 Apr 2014 16:47:11 +0200 Message-ID: From: Takashi Iwai To: Dan Carpenter Cc: Mateusz Guzik , gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, Laurent Navet , linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: line6: fix possible overrun In-Reply-To: <20140427224425.GQ26890@mwanda> References: <1398532162-23006-1-git-send-email-laurent.navet@gmail.com> <20140426204704.GB17562@mguzik.redhat.com> <20140426213137.GM26890@mwanda> <20140426215945.GC17562@mguzik.redhat.com> <20140427173932.GP26890@mwanda> <20140427200042.GA23846@mguzik.redhat.com> <20140427224425.GQ26890@mwanda> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Mon, 28 Apr 2014 01:44:25 +0300, Dan Carpenter wrote: > > On Sun, Apr 27, 2014 at 10:00:43PM +0200, Mateusz Guzik wrote: > > > > and a WARN_ON + -EINVAL in line6_init_audio to catch future > > > > offenders. > > > > > > Returning -EINVAL is a bad idea because it would break the driver > > > completely and make it unusable. > > > > > > > Well I would vote for returning the error anyway. > > I'm trying to be polite, but you are talking about adding regressions > deliberately... > > It's very rare for people to deliberately add regressions to the kernel. > I have only seen it one time before. I don't think Dan would be against returning -EINVAL if all the offender codes have been fixed (e.g. truncating strings to fit with the fixed arrays) at first. Then it'd be a good help to catch any future bugs. But, having -EINVAL without fixing the caller side means essentially that you're introducing the breakage intentionally although you know it certainly breaks, which is obviously bad. Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/