Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758059AbaD2PFc (ORCPT ); Tue, 29 Apr 2014 11:05:32 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:47926 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758012AbaD2PFb (ORCPT ); Tue, 29 Apr 2014 11:05:31 -0400 MIME-Version: 1.0 In-Reply-To: <20140428145223.GL26756@n2100.arm.linux.org.uk> References: <1398644860-22973-1-git-send-email-mporter@linaro.org> <20140428142950.GB30292@saruman.home> <20140428143709.GC7719@beef> <20140428145223.GL26756@n2100.arm.linux.org.uk> From: Barry Song Date: Tue, 29 Apr 2014 23:05:06 +0800 X-Google-Sender-Auth: foV9rniygbQhfwkHvs5hpe4Dvpc Message-ID: Subject: Re: [PATCH] ARM: l2c: prima2: only call l2x0_of_init() on matching nodes To: Russell King - ARM Linux Cc: Matt Porter , Felipe Balbi , Kevin Hilman , Linux ARM Kernel List , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2014-04-28 22:52 GMT+08:00 Russell King - ARM Linux : > On Mon, Apr 28, 2014 at 10:37:09AM -0400, Matt Porter wrote: >> The "fix" is tested against bcm281xx and bcm21664 as that is what the >> l2c cleanup breaks in -next. As mentioned, I don't have the sirfsoc h/w >> so this first attempt at a fix also breaks their platform. It can be >> addressed by adding those platform specific compatibles back to the dts, >> of course. >> >> I'd much prefer that the sirfsoc folks fix this...it's going to break >> other platforms in a multi v7 build. > > Well, it's about time we got rid of this from platform specific code > anyway, taking it away from platform maintainers to mess around with. > So that's what I'm doing. > > It's worth noting that if you build a single zImage with exynos also > enabled, then you also end up with an unconditional call from that > code to l2x0_of_init() with it's own magic numbers - and that applies > before my changes. > > So let's fix this properly and yank this crap from platform maintainers > fingers. i mentioned dropping specific dts compatible prop will break non-csr platforms in the mail thread "ARM: prima2: remove L2 cache size override" and i said i was going to send v2. you said you need it before rc6. now it has been sent, but i am sorry it is not against next-20140424. > > -- > FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly > improving, and getting towards what was expected from it. -barry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/