Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757816AbaD2PLY (ORCPT ); Tue, 29 Apr 2014 11:11:24 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:44230 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757656AbaD2PLT (ORCPT ); Tue, 29 Apr 2014 11:11:19 -0400 MIME-Version: 1.0 In-Reply-To: <20140428134047.GA7719@beef> References: <1398644860-22973-1-git-send-email-mporter@linaro.org> <20140428091532.GG26756@n2100.arm.linux.org.uk> <20140428134047.GA7719@beef> From: Barry Song Date: Tue, 29 Apr 2014 23:10:57 +0800 X-Google-Sender-Auth: wIT-c8pyFYEFIA2_5m065fKkKa4 Message-ID: Subject: Re: [PATCH] ARM: l2c: prima2: only call l2x0_of_init() on matching nodes To: Matt Porter Cc: Russell King - ARM Linux , Kevin Hilman , Linux ARM Kernel List , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2014-04-28 21:40 GMT+08:00 Matt Porter : > On Mon, Apr 28, 2014 at 10:15:33AM +0100, Russell King wrote: >> On Sun, Apr 27, 2014 at 08:27:40PM -0400, Matt Porter wrote: >> > l2x0_of_init() is executed unconditionally within the sirfsoc_l2x0_init() >> > early initcall. In a multi v7 kernel this causes bcm281xx and bcm21664 >> > platform to fail boot since they have their own pre l2x0 init sequence >> > that is required. Fix this by checking that a matching OF ID is present >> > before calling l2x0_of_init(). >> > >> > Reported-by: Kevin Hilman >> > Signed-off-by: Matt Porter >> > --- >> > Applies against next-20140424 to fix the issue introduced in >> > 50655e6 ARM: l2c: prima2: remove cache size override >> >> Err, this only "fixes" it because it effectively disables the L2 cache >> _entirely_ - in the above commit, I kill your private compatible strings. >> >> This doesn't make sense. If the cache is already enabled, then the L2C >> code won't try to enable it again. > > Ok, please suggest an alternative. You merged this commit..it looks like > it had no ack from the platform maintainer..and I don't have hardware. > The commit is wrong, we can't have every platform executing sirfsoc's > l2x0_of_init() call/parameters by having this stuff in an early initcall > like that. > > It would be pretty straightforward to add those private compatibles > back so the approach works. If not, we need to move this to > .init_machine where it's guaranteed to only run on sirfsoc. these has been one V1 patch at http://permalink.gmane.org/gmane.linux.ports.arm.kernel/316312 my v2 has moved to init_irq() as Russell's suggestion. > > -Matt -barry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/