Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933810AbaD2RG0 (ORCPT ); Tue, 29 Apr 2014 13:06:26 -0400 Received: from mga03.intel.com ([143.182.124.21]:61244 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932759AbaD2RGY (ORCPT ); Tue, 29 Apr 2014 13:06:24 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,952,1389772800"; d="scan'208";a="425490888" Message-ID: <535FDE71.7000601@linux.intel.com> Date: Tue, 29 Apr 2014 20:16:33 +0300 From: Mathias Nyman User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Julius Werner , Alan Stern CC: Sarah Sharp , Mathias Nyman , Greg Kroah-Hartman , "linux-usb@vger.kernel.org" , LKML , Vincent Palatin , Andrew Bresticker , Jim Lin Subject: Re: [PATCH] usb: xhci: Correct last context entry calculation for Configure Endpoint References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/29/2014 06:11 AM, Julius Werner wrote: > *bump* > > Sarah, Mathias, can we decide how to proceed with this? I think the > section Alan quoted is a pretty good argument in favor of my > interpretation (although of course this would not be the first time > that two sections of a spec contradict each other). But more > importantly, we have a case that just generates a clearly wrong Slot > Context right now (the one that only drops endpoints), and I see no > way how you could construct a correct Slot Context for that case with > Sarah's interpretation. We need to resolve that somehow. We discussed with Sarah that we should try this out and queue it for usb-linus. This clearly fixes the generation of a invalid slot context if all endpoints are dropped. But because there hasn't been any reported issue about the other case this changes (always setting context entries to last valid ep in target configuration), and spec still has this tiny contradiction in this case, we should keep this out of stable. At least for now, until it gets some real world testing coverage. -Mathias -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/