Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934031AbaD2SQN (ORCPT ); Tue, 29 Apr 2014 14:16:13 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:46361 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933757AbaD2SQM (ORCPT ); Tue, 29 Apr 2014 14:16:12 -0400 Date: Tue, 29 Apr 2014 19:16:10 +0100 From: Al Viro To: Miklos Szeredi Cc: Linus Torvalds , Linux Kernel Mailing List , linux-fsdevel Subject: Re: dcache shrink list corruption? Message-ID: <20140429181610.GJ18016@ZenIV.linux.org.uk> References: <20140429160139.GA3113@tucsk.piliscsaba.szeredi.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 29, 2014 at 08:03:24PM +0200, Miklos Szeredi wrote: > Introducing a new per-sb lock should be OK. > > Another idea, which could have subtler effects, is simply not to kill > a dentry that is on the shrink list (indicated by > DCACHE_SHRINK_LIST), since it's bound to get killed anyway. But > that's a change in behaviour... Umm... You mean, if final dput() finds dentry already on shrink list, just leave it there and return? Might get really painful - the code that knows it's holding the last reference to already unhashed dentry might get a nasty surprise when dput() returns before it's killed off. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/