Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965365AbaD2WUt (ORCPT ); Tue, 29 Apr 2014 18:20:49 -0400 Received: from mail-ve0-f174.google.com ([209.85.128.174]:51709 "EHLO mail-ve0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965265AbaD2WUo (ORCPT ); Tue, 29 Apr 2014 18:20:44 -0400 MIME-Version: 1.0 In-Reply-To: <20140429071610.63ccdfae.m.chehab@samsung.com> References:

<20140428214000.GA9187@gmail.com> <20140429071610.63ccdfae.m.chehab@samsung.com> From: Brian Healy Date: Tue, 29 Apr 2014 23:20:23 +0100 Message-ID: Subject: Re: [PATCH] Kernel 3.15-rc2 : Peak DVB-T USB tuner device ids for rtl28xxu driver To: Mauro Carvalho Chehab Cc: Antti Palosaari , Linus Torvalds , Linux Kernel Mailing List , Linux Media Mailing List Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks Mauro, I'll know for next time. It's my first patch submission so wasn't aware of the formatting rules. Brian On 29 April 2014 15:16, Mauro Carvalho Chehab wrote: > Em Mon, 28 Apr 2014 22:40:00 +0100 > Brian Healy escreveu: > >> From: Brian Healy >> To: Antti Palosaari , Mauro Carvalho Chehab >> Cc: Linus Torvalds , Linux Kernel Mailing List , Linux Media Mailing List >> Subject: Re: [PATCH] Kernel 3.15-rc2 : Peak DVB-T USB tuner device ids for rtl28xxu driver >> Date: Mon, 28 Apr 2014 22:40:00 +0100 >> Sender: linux-media-owner@vger.kernel.org >> User-Agent: Mutt/1.5.21 (2010-09-15) >> >> On Sun, Apr 27, 2014 at 03:19:12PM -0700, Linus Torvalds wrote: >> >> Hi Linus, >> >> apologies, i've changed email clients in order to preserve the >> formatting this time around. The patch is now included inline as an >> attachment. I ran the script but noticed you've already cc'd the >> appropriate people. >> >> Brian. >> >> >> Resubmitting modified patch. It's purpose is to add the appropriate >> device/usb ids for the "Peak DVT-B usb dongle" to the rtl28xxu.c driver. >> >> Signed-off-by: Brian Healy gmail.com> >> >> >> > Brian, please use >> > >> > ./scripts/get_maintainer -f drivers/media/usb/dvb-usb-v2/rtl28xxu.c >> > >> > to get the proper people to send this to, so that it doesn't get lost >> > in the flood in lkml. >> > >> > The indentation of that new entry also seems to be suspect, in that it >> > doesn't match the ones around it. >> > >> > Quoting full email for context for people added. >> > >> > Linus >> > >> >> diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c >> index 61d196e..b6e20cc 100644 >> --- a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c >> +++ b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c >> @@ -1499,6 +1499,8 @@ static const struct usb_device_id rtl28xxu_id_table[] = { >> &rtl2832u_props, "Crypto ReDi PC 50 A", NULL) }, >> { DVB_USB_DEVICE(USB_VID_KYE, 0x707f, >> &rtl2832u_props, "Genius TVGo DVB-T03", NULL) }, >> + { DVB_USB_DEVICE(USB_VID_KWORLD_2, 0xd395, >> + &rtl2832u_props, "Peak DVB-T USB", NULL) }, > > Patch is still a little odd, as you're using spaces for indenting, instead of > tabs, but I can fix it with my scripts. Next time, please use tabs. > > Also, specifically in the case of patches for linux-media, you don't need > to c/c me. Just send the patch to linux-media and to the driver maintainer > (Antti, in this case). > > My workflow is to pick the patches from patchwork: > https://patchwork.linuxtv.org/patch/23792/ > after receiving Antti's ack. > > Alternatively, Antti may opt to put it on his git tree, sending it to me > latter together of other patches he may have for the devices he maintains. > >> >> /* RTL2832P devices: */ >> { DVB_USB_DEVICE(USB_VID_HANFTEK, 0x0131, > > Thanks, > Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/